refactor!: move local issue tracker rule settings from $GIT_DIR/sourcegit.issuetracker to default repo's git config (#1725)

Signed-off-by: leo <[email protected]>

Author: love-linger

src/Commands/IssueTracker.cs

@@ -11,15 +11,25 @@ public IssueTracker(string repo, string storage)
         {
             WorkingDirectory = repo;
             Context = repo;
-            _storage = storage;
+
+            if (string.IsNullOrEmpty(storage))
+            {
+                _isStorageFileExists = true;
+                _baseArg = "config --local";
+            }
+            else
+            {
+                _isStorageFileExists = File.Exists(storage);
+                _baseArg = $"config -f {storage.Quoted()}";
+            }
         }
 
         public async Task ReadAllAsync(List<Models.IssueTracker> outs, bool isShared)
         {
-            if (!File.Exists(_storage))
+            if (!_isStorageFileExists)
                 return;
 
-            Args = $"config -f {_storage.Quoted()} -l";
+            Args = $"{_baseArg} -l";
 
             var rs = await ReadToEndAsync().ConfigureAwait(false);
             if (rs.IsSuccess)
@@ -57,12 +67,12 @@ public async Task ReadAllAsync(List<Models.IssueTracker> outs, bool isShared)
 
         public async Task<bool> AddAsync(Models.IssueTracker rule)
         {
-            Args = $"config -f {_storage.Quoted()} issuetracker.{rule.Name.Quoted()}.regex {rule.RegexString.Quoted()}";
+            Args = $"{_baseArg} issuetracker.{rule.Name.Quoted()}.regex {rule.RegexString.Quoted()}";
 
             var succ = await ExecAsync().ConfigureAwait(false);
             if (succ)
             {
-                Args = $"config -f {_storage.Quoted()} issuetracker.{rule.Name.Quoted()}.url {rule.URLTemplate.Quoted()}";
+                Args = $"{_baseArg} issuetracker.{rule.Name.Quoted()}.url {rule.URLTemplate.Quoted()}";
                 return await ExecAsync().ConfigureAwait(false);
             }
 
@@ -71,10 +81,10 @@ public async Task<bool> AddAsync(Models.IssueTracker rule)
 
         public async Task<bool> RemoveAsync(Models.IssueTracker rule)
         {
-            if (!File.Exists(_storage))
+            if (!_isStorageFileExists)
                 return true;
 
-            Args = $"config -f {_storage.Quoted()} --remove-section issuetracker.{rule.Name.Quoted()}";
+            Args = $"{_baseArg} --remove-section issuetracker.{rule.Name.Quoted()}";
             return await ExecAsync().ConfigureAwait(false);
         }
 
@@ -89,6 +99,7 @@ private Models.IssueTracker FindOrAdd(List<Models.IssueTracker> rules, string ru
             return rule;
         }
 
-        private readonly string _storage;
+        private readonly bool _isStorageFileExists;
+        private readonly string _baseArg;
     }
 }

src/ViewModels/Repository.cs

@@ -1715,8 +1715,7 @@ private LauncherPage GetOwnerPage()
 
         private Commands.IssueTracker CreateIssueTrackerCommand(bool shared)
         {
-            var storage = shared ? $"{_fullpath}/.issuetracker" : $"{_gitDir}/sourcegit.issuetracker";
-            return new Commands.IssueTracker(_fullpath, storage);
+            return new Commands.IssueTracker(_fullpath, shared ? $"{_fullpath}/.issuetracker" : null);
         }
 
         private BranchTreeNode.Builder BuildBranchTree(List<Models.Branch> branches, List<Models.Remote> remotes)