code_review: PR #1078

- Remove `ForceEnglishLocale` because we want all `git` outputs in English
- Remove locale settings for `ExecuteCustomAction`

Signed-off-by: leo <[email protected]>

Author: love-linger

src/Commands/Command.cs

@@ -37,7 +37,6 @@ public enum EditorType
         public string Args { get; set; } = string.Empty;
         public bool RaiseError { get; set; } = true;
         public bool TraitErrorAsOutput { get; set; } = false;
-        protected bool ForceEnglishLocale { get; set; } = false;
 
         public bool Exec()
         {
@@ -193,8 +192,8 @@ private ProcessStartInfo CreateGitStartInfo()
             if (!start.Environment.ContainsKey("GIT_SSH_COMMAND") && !string.IsNullOrEmpty(SSHKey))
                 start.Environment.Add("GIT_SSH_COMMAND", $"ssh -i '{SSHKey}'");
 
-            // Force using en_US.UTF-8 locale to avoid GCM crash
-            if (ForceEnglishLocale || OperatingSystem.IsLinux())
+            // Force using en_US.UTF-8 locale
+            if (OperatingSystem.IsLinux())
             {
                 start.Environment.Add("LANG", "C");
                 start.Environment.Add("LC_ALL", "C");

src/Commands/ExecuteCustomAction.cs

@@ -17,13 +17,6 @@ public static void Run(string repo, string file, string args)
             start.CreateNoWindow = true;
             start.WorkingDirectory = repo;
 
-            // Force using en_US.UTF-8 locale to avoid GCM crash
-            if (OperatingSystem.IsLinux())
-            {
-                start.Environment.Add("LANG", "C");
-                start.Environment.Add("LC_ALL", "C");
-            }
-
             // Fix macOS `PATH` env
             if (OperatingSystem.IsMacOS() && !string.IsNullOrEmpty(Native.OS.CustomPathEnv))
                 start.Environment.Add("PATH", Native.OS.CustomPathEnv);
@@ -51,13 +44,6 @@ public static void RunAndWait(string repo, string file, string args, Action<stri
             start.StandardErrorEncoding = Encoding.UTF8;
             start.WorkingDirectory = repo;
 
-            // Force using en_US.UTF-8 locale to avoid GCM crash
-            if (OperatingSystem.IsLinux())
-            {
-                start.Environment.Add("LANG", "C");
-                start.Environment.Add("LC_ALL", "C");
-            }
-
             // Fix macOS `PATH` env
             if (OperatingSystem.IsMacOS() && !string.IsNullOrEmpty(Native.OS.CustomPathEnv))
                 start.Environment.Add("PATH", Native.OS.CustomPathEnv);

src/Commands/QueryBranches.cs

@@ -14,7 +14,6 @@ public QueryBranches(string repo)
         {
             WorkingDirectory = repo;
             Context = repo;
-            ForceEnglishLocale = true;
             Args = "branch -l --all -v --format=\"%(refname)%00%(objectname)%00%(HEAD)%00%(upstream)%00%(upstream:trackshort)\"";
         }