enhance: clean up popup before closing tab

love-linger · love-linger · commit 33de0fe21931 · 2025-08-13T11:06:56.000+08:00
Signed-off-by: leo &lt;longshuang@msn.cn&gt;
diff --git a/src/ViewModels/Launcher.cs b/src/ViewModels/Launcher.cs
@@ -265,6 +265,7 @@ public void CloseTab(LauncherPage page)
                     Welcome.Instance.ClearSearchFilter();
                     last.Node = new RepositoryNode() { Id = Guid.NewGuid().ToString() };
                     last.Data = Welcome.Instance;
+                    last.Popup?.Cleanup();
                     last.Popup = null;
                     UpdateTitle();
 
@@ -459,6 +460,8 @@ private void CloseRepositoryInTab(LauncherPage page, bool removeFromWorkspace =
                 repo.Close();
             }
 
+            page.Popup?.Cleanup();
+            page.Popup = null;
             page.Data = null;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -265,6 +265,7 @@ public void CloseTab(LauncherPage page)`
`265`	`265`	`Welcome.Instance.ClearSearchFilter();`
`266`	`266`	`last.Node = new RepositoryNode() { Id = Guid.NewGuid().ToString() };`
`267`	`267`	`last.Data = Welcome.Instance;`
	`268`	`+ last.Popup?.Cleanup();`
`268`	`269`	`last.Popup = null;`
`269`	`270`	`UpdateTitle();`
`270`	`271`
`@@ -459,6 +460,8 @@ private void CloseRepositoryInTab(LauncherPage page, bool removeFromWorkspace =`
`459`	`460`	`repo.Close();`
`460`	`461`	`}`
`461`	`462`
	`463`	`+ page.Popup?.Cleanup();`
	`464`	`+ page.Popup = null;`
`462`	`465`	`page.Data = null;`
`463`	`466`	`}`
`464`	`467`