enhance: always turn off --color=<when> and --ext-diff when calling git diff in SourceGit (#1922)

Signed-off-by: leo <[email protected]>

Author: love-linger

src/Commands/Diff.cs

@@ -26,11 +26,11 @@ public Diff(string repo, Models.DiffOption opt, int unified, bool ignoreWhitespa
             Context = repo;
 
             if (ignoreWhitespace)
-                Args = $"diff --no-ext-diff --patch --ignore-all-space --unified={unified} {opt}";
+                Args = $"diff --no-color --no-ext-diff --patch --ignore-all-space --unified={unified} {opt}";
             else if (Models.DiffOption.IgnoreCRAtEOL)
-                Args = $"diff --no-ext-diff --patch --ignore-cr-at-eol --unified={unified} {opt}";
+                Args = $"diff --no-color --no-ext-diff --patch --ignore-cr-at-eol --unified={unified} {opt}";
             else
-                Args = $"diff --no-ext-diff --patch --unified={unified} {opt}";
+                Args = $"diff --no-color --no-ext-diff --patch --unified={unified} {opt}";
         }
 
         public async Task<Models.DiffResult> ReadAsync()

src/Commands/GenerateCommitMessage.cs

@@ -17,7 +17,7 @@ public GetDiffContent(string repo, Models.DiffOption opt)
             {
                 WorkingDirectory = repo;
                 Context = repo;
-                Args = $"diff --diff-algorithm=minimal {opt}";
+                Args = $"diff --no-color --no-ext-diff --diff-algorithm=minimal {opt}";
             }
 
             public async Task<Result> ReadAsync()

src/Commands/IsBinary.cs

@@ -12,7 +12,7 @@ public IsBinary(string repo, string commit, string path)
         {
             WorkingDirectory = repo;
             Context = repo;
-            Args = $"diff {Models.Commit.EmptyTreeSHA1} {commit} --numstat -- {path.Quoted()}";
+            Args = $"diff --no-color --no-ext-diff --numstat {Models.Commit.EmptyTreeSHA1} {commit} -- {path.Quoted()}";
             RaiseError = false;
         }
 

src/Commands/IsConflictResolved.cs

@@ -10,7 +10,7 @@ public IsConflictResolved(string repo, Models.Change change)
 
             WorkingDirectory = repo;
             Context = repo;
-            Args = $"diff -a --ignore-cr-at-eol --check {opt}";
+            Args = $"diff --no-color --no-ext-diff -a --ignore-cr-at-eol --check {opt}";
         }
 
         public bool GetResult()

src/Commands/SaveChangesAsPatch.cs

@@ -54,7 +54,7 @@ private static async Task<bool> ProcessSingleChangeAsync(string repo, Models.Dif
             var starter = new ProcessStartInfo();
             starter.WorkingDirectory = repo;
             starter.FileName = Native.OS.GitExecutable;
-            starter.Arguments = $"diff --ignore-cr-at-eol --unified=4 {opt}";
+            starter.Arguments = $"diff --no-color --no-ext-diff --ignore-cr-at-eol --unified=4 {opt}";
             starter.UseShellExecute = false;
             starter.CreateNoWindow = true;
             starter.WindowStyle = ProcessWindowStyle.Hidden;