code_review: commit b969ac1

- The return code of `AutoRemoveInvalidNode`  is never used
- It's not necessary to sort all nodes after re-scan default clone dir. Because `FindOrAddNodeByRepositoryPath` makes sure added node is ordered
- Add a new parameter `save` to `FindOrAddNodeByRepositoryPath` method, and disable it while scanning. Instead, we will save it after scan finished.

Signed-off-by: leo <[email protected]>

Author: love-linger

src/ViewModels/Preferences.cs

@@ -453,17 +453,12 @@ public void SortNodes(List<RepositoryNode> collection)
             });
         }
 
-        public void SortAllNodes()
-        {
-            SortNodesRecursive(RepositoryNodes);
-        }
-
         public RepositoryNode FindNode(string id)
         {
             return FindNodeRecursive(id, RepositoryNodes);
         }
 
-        public RepositoryNode FindOrAddNodeByRepositoryPath(string repo, RepositoryNode parent, bool shouldMoveNode)
+        public RepositoryNode FindOrAddNodeByRepositoryPath(string repo, RepositoryNode parent, bool shouldMoveNode, bool save = true)
         {
             var normalized = repo.Replace('\\', '/').TrimEnd('/');
 
@@ -478,11 +473,11 @@ public RepositoryNode FindOrAddNodeByRepositoryPath(string repo, RepositoryNode
                     IsRepository = true,
                 };
 
-                AddNode(node, parent, true);
+                AddNode(node, parent, save);
             }
             else if (shouldMoveNode)
             {
-                MoveNode(node, parent, true);
+                MoveNode(node, parent, save);
             }
 
             return node;
@@ -514,13 +509,12 @@ public void SortByRenamedNode(RepositoryNode node)
         {
             var container = FindNodeContainer(node, RepositoryNodes);
             SortNodes(container);
-
             Save();
         }
 
-        public bool AutoRemoveInvalidNode()
+        public void AutoRemoveInvalidNode()
         {
-            return RemoveInvalidRepositoriesRecursive(RepositoryNodes);
+            RemoveInvalidRepositoriesRecursive(RepositoryNodes);
         }
 
         public void Save()

src/ViewModels/ScanRepositories.cs

@@ -53,20 +53,17 @@ public override Task<bool> Sure()
                         var parent = new DirectoryInfo(f.Path).Parent!.FullName.Replace('\\', '/').TrimEnd('/');
                         if (parent.Equals(normalizedRoot, StringComparison.Ordinal))
                         {
-                            Preferences.Instance.FindOrAddNodeByRepositoryPath(f.Path, null, false);
+                            Preferences.Instance.FindOrAddNodeByRepositoryPath(f.Path, null, false, false);
                         }
                         else if (parent.StartsWith(normalizedRoot, StringComparison.Ordinal))
                         {
                             var relative = parent.Substring(normalizedRoot.Length).TrimStart('/');
                             var group = FindOrCreateGroupRecursive(Preferences.Instance.RepositoryNodes, relative);
-                            Preferences.Instance.FindOrAddNodeByRepositoryPath(f.Path, group, false);
+                            Preferences.Instance.FindOrAddNodeByRepositoryPath(f.Path, group, false, false);
                         }
                     }
 
                     Preferences.Instance.AutoRemoveInvalidNode();
-
-                    // Sort & Save unconditionally after a complete rescan.
-                    Preferences.Instance.SortAllNodes();
                     Preferences.Instance.Save();
 
                     Welcome.Instance.Refresh();