fix: System.ArgumentException when hover the commit link multiple times before the first time tooltip shows (#765)

love-linger · love-linger · commit 4aad6a7f8610 · 2024-11-29T10:26:36.000+08:00
diff --git a/src/ViewModels/CherryPick.cs b/src/ViewModels/CherryPick.cs
@@ -1,5 +1,4 @@
 ﻿using System.Collections.Generic;
-using System.Text;
 using System.Threading.Tasks;
 
 namespace SourceGit.ViewModels
diff --git a/src/Views/CommitMessagePresenter.cs b/src/Views/CommitMessagePresenter.cs
@@ -296,7 +296,8 @@ private void ProcessHoverCommitLink(Models.Hyperlink link)
                         if (currentParent is { DataContext: ViewModels.CommitDetail currentDetail } &&
                             currentDetail.Commit.SHA == lastDetailCommit)
                         {
-                            _inlineCommits.Add(sha, c);
+                            if (!_inlineCommits.ContainsKey(sha))
+                                _inlineCommits.Add(sha, c);
 
                             // Make sure user still hovers the target SHA.
                             if (_lastHover == link && c != null)

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`using System.Collections.Generic;`
`2`		`-using System.Text;`
`3`	`2`	`using System.Threading.Tasks;`
`4`	`3`
`5`	`4`	`namespace SourceGit.ViewModels`
Original file line number	Diff line number	Diff line change
`@@ -296,7 +296,8 @@ private void ProcessHoverCommitLink(Models.Hyperlink link)`
`296`	`296`	`if (currentParent is { DataContext: ViewModels.CommitDetail currentDetail } &&`
`297`	`297`	`currentDetail.Commit.SHA == lastDetailCommit)`
`298`	`298`	`{`
`299`		`- _inlineCommits.Add(sha, c);`
	`299`	`+ if (!_inlineCommits.ContainsKey(sha))`
	`300`	`+ _inlineCommits.Add(sha, c);`
`300`	`301`
`301`	`302`	`// Make sure user still hovers the target SHA.`
`302`	`303`	`if (_lastHover == link && c != null)`