enhance: only remember active tab index of commit details panel in HISTORY page

Signed-off-by: leo <[email protected]>

Author: love-linger

src/ViewModels/CommitDetail.cs

@@ -17,14 +17,13 @@ public partial class CommitDetail : ObservableObject, IDisposable
     {
         public int ActivePageIndex
         {
-            get => _repo.CommitDetailActivePageIndex;
+            get => _rememberActivePageIndex ? _repo.CommitDetailActivePageIndex : _activePageIndex;
             set
             {
-                if (_repo.CommitDetailActivePageIndex != value)
-                {
+                if (_rememberActivePageIndex)
                     _repo.CommitDetailActivePageIndex = value;
-                    OnPropertyChanged();
-                }
+                else
+                    _activePageIndex = value;
             }
         }
 
@@ -139,9 +138,10 @@ public bool CanOpenRevisionFileWithDefaultEditor
             private set => SetProperty(ref _canOpenRevisionFileWithDefaultEditor, value);
         }
 
-        public CommitDetail(Repository repo)
+        public CommitDetail(Repository repo, bool rememberActivePageIndex)
         {
             _repo = repo;
+            _rememberActivePageIndex = rememberActivePageIndex;
             WebLinks = Models.CommitLink.Get(repo.Remotes);
         }
 
@@ -1026,6 +1026,8 @@ private Task ResetToParentRevision(Models.Change change)
         private static partial Regex REG_SHA_FORMAT();
 
         private Repository _repo = null;
+        private bool _rememberActivePageIndex = true;
+        private int _activePageIndex = 0;
         private Models.Commit _commit = null;
         private Models.CommitFullMessage _fullMessage = null;
         private Models.CommitSignInfo _signInfo = null;

src/ViewModels/DirHistories.cs

@@ -48,11 +48,11 @@ public DirHistories(Repository repo, string dir, string revision = null)
                 Title = dir;
 
             _repo = repo;
-            _detail = new CommitDetail(repo);
+            _detail = new CommitDetail(repo, false);
 
             Task.Run(() =>
             {
-                var commits = new Commands.QueryCommits(_repo.FullPath, $"--date-order -n 10000 {revision??string.Empty} -- \"{dir}\"", false).Result();
+                var commits = new Commands.QueryCommits(_repo.FullPath, $"--date-order -n 10000 {revision ?? string.Empty} -- \"{dir}\"", false).Result();
                 Dispatcher.UIThread.Invoke(() =>
                 {
                     Commits = commits;

src/ViewModels/Histories.cs

@@ -156,7 +156,7 @@ public void NavigateTo(string commitSHA)
                 }
                 else
                 {
-                    var commitDetail = new CommitDetail(_repo);
+                    var commitDetail = new CommitDetail(_repo, true);
                     commitDetail.Commit = commit;
                     DetailContext = commitDetail;
                 }
@@ -189,7 +189,7 @@ public void Select(IList commits)
                 }
                 else
                 {
-                    var commitDetail = new CommitDetail(_repo);
+                    var commitDetail = new CommitDetail(_repo, true);
                     commitDetail.Commit = commit;
                     DetailContext = commitDetail;
                 }

src/ViewModels/InteractiveRebase.cs

@@ -129,7 +129,7 @@ public InteractiveRebase(Repository repo, Models.Branch current, Models.Commit o
             Current = current;
             On = on;
             IsLoading = true;
-            DetailContext = new CommitDetail(repo);
+            DetailContext = new CommitDetail(repo, false);
 
             Task.Run(() =>
             {