Skip to content

Commit 4f4b90d

Browse files
committed
ux: re-order context menu items
Signed-off-by: leo <[email protected]>
1 parent 6d06815 commit 4f4b90d

File tree

2 files changed

+36
-34
lines changed

2 files changed

+36
-34
lines changed

src/ViewModels/CommitDetail.cs

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -509,16 +509,6 @@ public ContextMenu CreateRevisionFileContextMenu(Models.Object file)
509509

510510
var menu = new ContextMenu();
511511
var fullPath = Native.OS.GetAbsPath(_repo.FullPath, file.Path);
512-
var explore = new MenuItem();
513-
explore.Header = App.Text("RevealFile");
514-
explore.Icon = App.CreateMenuIcon("Icons.Explore");
515-
explore.IsEnabled = File.Exists(fullPath);
516-
explore.Click += (_, ev) =>
517-
{
518-
Native.OS.OpenInFileManager(fullPath, file.Type == Models.ObjectType.Blob);
519-
ev.Handled = true;
520-
};
521-
522512
var openWith = new MenuItem();
523513
openWith.Header = App.Text("OpenWith");
524514
openWith.Icon = App.CreateMenuIcon("Icons.OpenWith");
@@ -562,9 +552,19 @@ await Commands.SaveRevisionFile
562552
ev.Handled = true;
563553
};
564554

565-
menu.Items.Add(explore);
555+
var explore = new MenuItem();
556+
explore.Header = App.Text("RevealFile");
557+
explore.Icon = App.CreateMenuIcon("Icons.Explore");
558+
explore.IsEnabled = File.Exists(fullPath);
559+
explore.Click += (_, ev) =>
560+
{
561+
Native.OS.OpenInFileManager(fullPath, file.Type == Models.ObjectType.Blob);
562+
ev.Handled = true;
563+
};
564+
566565
menu.Items.Add(openWith);
567566
menu.Items.Add(saveAs);
567+
menu.Items.Add(explore);
568568
menu.Items.Add(new MenuItem() { Header = "-" });
569569

570570
var history = new MenuItem();

src/ViewModels/WorkingCopy.cs

Lines changed: 25 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using System;
1+
using System;
22
using System.Collections.Generic;
33
using System.IO;
44
using System.Threading.Tasks;
@@ -593,6 +593,7 @@ public ContextMenu CreateContextMenuForUnstagedChanges(string selectedSingleFold
593593
var diffWithMerger = new MenuItem();
594594
diffWithMerger.Header = App.Text("DiffWithMerger");
595595
diffWithMerger.Icon = App.CreateMenuIcon("Icons.OpenWith");
596+
diffWithMerger.Tag = OperatingSystem.IsMacOS() ? "⌘+⇧+D" : "Ctrl+Shift+D";
596597
diffWithMerger.Click += (sender, ev) =>
597598
{
598599
var toolType = Preferences.Instance.ExternalMergeToolType;
@@ -604,6 +605,17 @@ public ContextMenu CreateContextMenuForUnstagedChanges(string selectedSingleFold
604605
};
605606
menu.Items.Add(diffWithMerger);
606607

608+
var openWith = new MenuItem();
609+
openWith.Header = App.Text("OpenWith");
610+
openWith.Icon = App.CreateMenuIcon("Icons.OpenWith");
611+
openWith.IsEnabled = File.Exists(path);
612+
openWith.Click += (_, e) =>
613+
{
614+
Native.OS.OpenWithDefaultEditor(path);
615+
e.Handled = true;
616+
};
617+
menu.Items.Add(openWith);
618+
607619
var explore = new MenuItem();
608620
explore.Header = App.Text("RevealFile");
609621
explore.Icon = App.CreateMenuIcon("Icons.Explore");
@@ -615,17 +627,6 @@ public ContextMenu CreateContextMenuForUnstagedChanges(string selectedSingleFold
615627
e.Handled = true;
616628
};
617629
menu.Items.Add(explore);
618-
619-
var openWith = new MenuItem();
620-
openWith.Header = App.Text("OpenWith");
621-
openWith.Icon = App.CreateMenuIcon("Icons.OpenWith");
622-
openWith.IsEnabled = File.Exists(path);
623-
openWith.Click += (_, e) =>
624-
{
625-
Native.OS.OpenWithDefaultEditor(path);
626-
e.Handled = true;
627-
};
628-
menu.Items.Add(openWith);
629630
menu.Items.Add(new MenuItem() { Header = "-" });
630631

631632
if (change.IsConflicted)
@@ -1260,6 +1261,7 @@ public ContextMenu CreateContextMenuForStagedChanges(string selectedSingleFolder
12601261
var diffWithMerger = new MenuItem();
12611262
diffWithMerger.Header = App.Text("DiffWithMerger");
12621263
diffWithMerger.Icon = App.CreateMenuIcon("Icons.OpenWith");
1264+
diffWithMerger.Tag = OperatingSystem.IsMacOS() ? "⌘+⇧+D" : "Ctrl+Shift+D";
12631265
diffWithMerger.Click += (sender, ev) =>
12641266
{
12651267
var toolType = Preferences.Instance.ExternalMergeToolType;
@@ -1270,6 +1272,16 @@ public ContextMenu CreateContextMenuForStagedChanges(string selectedSingleFolder
12701272
ev.Handled = true;
12711273
};
12721274

1275+
var openWith = new MenuItem();
1276+
openWith.Header = App.Text("OpenWith");
1277+
openWith.Icon = App.CreateMenuIcon("Icons.OpenWith");
1278+
openWith.IsEnabled = File.Exists(path);
1279+
openWith.Click += (_, e) =>
1280+
{
1281+
Native.OS.OpenWithDefaultEditor(path);
1282+
e.Handled = true;
1283+
};
1284+
12731285
var explore = new MenuItem();
12741286
explore.IsEnabled = File.Exists(path) || Directory.Exists(path);
12751287
explore.Header = App.Text("RevealFile");
@@ -1281,16 +1293,6 @@ public ContextMenu CreateContextMenuForStagedChanges(string selectedSingleFolder
12811293
e.Handled = true;
12821294
};
12831295

1284-
var openWith = new MenuItem();
1285-
openWith.Header = App.Text("OpenWith");
1286-
openWith.Icon = App.CreateMenuIcon("Icons.OpenWith");
1287-
openWith.IsEnabled = File.Exists(path);
1288-
openWith.Click += (_, e) =>
1289-
{
1290-
Native.OS.OpenWithDefaultEditor(path);
1291-
e.Handled = true;
1292-
};
1293-
12941296
var unstage = new MenuItem();
12951297
unstage.Header = App.Text("FileCM.Unstage");
12961298
unstage.Icon = App.CreateMenuIcon("Icons.File.Remove");
@@ -1338,8 +1340,8 @@ public ContextMenu CreateContextMenuForStagedChanges(string selectedSingleFolder
13381340
};
13391341

13401342
menu.Items.Add(diffWithMerger);
1341-
menu.Items.Add(explore);
13421343
menu.Items.Add(openWith);
1344+
menu.Items.Add(explore);
13431345
menu.Items.Add(new MenuItem() { Header = "-" });
13441346
menu.Items.Add(unstage);
13451347
menu.Items.Add(stash);

0 commit comments

Comments
 (0)