Skip to content

Commit 5301a36

Browse files
committed
ux: re-design the layout for Interactive Rebase window that tries to fix issue #1037
Signed-off-by: leo <[email protected]>
1 parent d4bcc60 commit 5301a36

File tree

1 file changed

+29
-34
lines changed

1 file changed

+29
-34
lines changed

src/Views/InteractiveRebase.axaml

Lines changed: 29 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@
7777

7878
<ListBox.ItemTemplate>
7979
<DataTemplate DataType="vm:InteractiveRebaseItem">
80-
<Grid ColumnDefinitions="16,110,*,Auto" Margin="8,0" ClipToBounds="True">
80+
<Grid ColumnDefinitions="16,110,*,32,108,96,Auto,32,32" Margin="8,0" ClipToBounds="True">
8181
<!-- Drag & Drop Anchor -->
8282
<Border Grid.Column="0" Background="Transparent"
8383
Loaded="OnSetupRowHeaderDragDrop"
@@ -188,44 +188,39 @@
188188
<TextBlock Grid.Column="1" Classes="primary" Margin="0,0,4,0" Text="{Binding Subject}"/>
189189
</Grid>
190190

191-
<Grid Grid.Column="3" ColumnDefinitions="32,108,96,Auto,32,32" IsHitTestVisible="False" ClipToBounds="True">
192-
<!-- Author Avatar -->
193-
<v:Avatar Grid.Column="0"
194-
Width="16" Height="16"
195-
Margin="8,0,0,0"
196-
VerticalAlignment="Center"
197-
User="{Binding Commit.Author}"/>
191+
<!-- Author Avatar -->
192+
<v:Avatar Grid.Column="3"
193+
Width="16" Height="16"
194+
Margin="8,0,0,0"
195+
VerticalAlignment="Center"
196+
User="{Binding Commit.Author}"/>
198197

199-
<!-- Author Name -->
200-
<TextBlock Grid.Column="1"
201-
Classes="primary"
202-
MaxWidth="90"
203-
Margin="6,0,12,0"
204-
Text="{Binding Commit.Author.Name}"
205-
HorizontalAlignment="Left"/>
198+
<!-- Author Name -->
199+
<Border Grid.Column="4" ClipToBounds="True">
200+
<TextBlock Classes="primary" Margin="6,0,12,0" Text="{Binding Commit.Author.Name}"/>
201+
</Border>
206202

207-
<!-- Commit SHA -->
208-
<Border Grid.Column="2" ClipToBounds="True">
209-
<TextBlock Classes="primary"
210-
Text="{Binding Commit.SHA, Converter={x:Static c:StringConverters.ToShortSHA}}"
211-
HorizontalAlignment="Center"/>
212-
</Border>
203+
<!-- Commit SHA -->
204+
<Border Grid.Column="5" ClipToBounds="True">
205+
<TextBlock Classes="primary"
206+
Text="{Binding Commit.SHA, Converter={x:Static c:StringConverters.ToShortSHA}}"
207+
HorizontalAlignment="Center"/>
208+
</Border>
213209

214-
<!-- Commit Time -->
215-
<Border Grid.Column="3" ClipToBounds="True">
216-
<TextBlock Classes="primary" Text="{Binding Commit.CommitterTimeStr}" Margin="8,0"/>
217-
</Border>
210+
<!-- Commit Time -->
211+
<Border Grid.Column="6">
212+
<TextBlock Classes="primary" Text="{Binding Commit.CommitterTimeStr}" Margin="8,0"/>
213+
</Border>
218214

219-
<!-- MoveUp Button -->
220-
<Button Grid.Column="4" Classes="icon_button" Click="OnMoveItemUp" ToolTip.Tip="Alt+Up">
221-
<Path Width="14" Height="14" Margin="0,4,0,0" Data="{StaticResource Icons.Up}"/>
222-
</Button>
215+
<!-- MoveUp Button -->
216+
<Button Grid.Column="7" Classes="icon_button" Click="OnMoveItemUp" ToolTip.Tip="Alt+Up">
217+
<Path Width="14" Height="14" Margin="0,4,0,0" Data="{StaticResource Icons.Up}"/>
218+
</Button>
223219

224-
<!-- MoveDown Button -->
225-
<Button Grid.Column="5" Classes="icon_button" Click="OnMoveItemDown" ToolTip.Tip="Alt+Down">
226-
<Path Width="14" Height="14" Margin="0,4,0,0" Data="{StaticResource Icons.Down}"/>
227-
</Button>
228-
</Grid>
220+
<!-- MoveDown Button -->
221+
<Button Grid.Column="8" Classes="icon_button" Click="OnMoveItemDown" ToolTip.Tip="Alt+Down">
222+
<Path Width="14" Height="14" Margin="0,4,0,0" Data="{StaticResource Icons.Down}"/>
223+
</Button>
229224
</Grid>
230225
</DataTemplate>
231226
</ListBox.ItemTemplate>

0 commit comments

Comments
 (0)