Skip to content

Commit 66517fd

Browse files
authored
enhance: add tooltips to various UI elements for better accessibility (#1097)
* enhance: add tooltips to various UI elements for better accessibility * refactor: simplify user string conversion
1 parent a46e525 commit 66517fd

File tree

5 files changed

+26
-7
lines changed

5 files changed

+26
-7
lines changed

src/Models/User.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,11 @@ public static User FindOrAdd(string data)
4343
return _caches.GetOrAdd(data, key => new User(key));
4444
}
4545

46+
public override string ToString()
47+
{
48+
return $"{Name} <{Email}>";
49+
}
50+
4651
private static ConcurrentDictionary<string, User> _caches = new ConcurrentDictionary<string, User>();
4752
private readonly int _hash;
4853
}

src/Views/ChangeCollectionView.axaml

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@
3939
<Grid ColumnDefinitions="16,Auto,Auto,*"
4040
Margin="{Binding Depth, Converter={x:Static c:IntConverters.ToTreeMargin}}"
4141
Background="Transparent"
42-
DoubleTapped="OnRowDoubleTapped">
42+
DoubleTapped="OnRowDoubleTapped"
43+
ToolTip.Tip="{Binding FullPath}">
4344
<v:ChangeTreeNodeToggleButton Grid.Column="0"
4445
Classes="tree_expander"
4546
Focusable="False"
@@ -71,7 +72,10 @@
7172
SelectionChanged="OnRowSelectionChanged">
7273
<ListBox.ItemTemplate>
7374
<DataTemplate DataType="m:Change">
74-
<Grid ColumnDefinitions="Auto,Auto,Auto,*" Background="Transparent" DoubleTapped="OnRowDoubleTapped">
75+
<Grid ColumnDefinitions="Auto,Auto,Auto,*"
76+
Background="Transparent"
77+
DoubleTapped="OnRowDoubleTapped"
78+
ToolTip.Tip="{Binding Path}">
7579
<v:ChangeStatusIcon Grid.Column="0"
7680
Width="14" Height="14"
7781
Margin="4,0,0,0"
@@ -100,7 +104,10 @@
100104
SelectionChanged="OnRowSelectionChanged">
101105
<ListBox.ItemTemplate>
102106
<DataTemplate DataType="m:Change">
103-
<Grid ColumnDefinitions="Auto,Auto,*" Background="Transparent" DoubleTapped="OnRowDoubleTapped">
107+
<Grid ColumnDefinitions="Auto,Auto,*"
108+
Background="Transparent"
109+
DoubleTapped="OnRowDoubleTapped"
110+
ToolTip.Tip="{Binding Path}">
104111
<v:ChangeStatusIcon Grid.Column="0"
105112
Width="14" Height="14"
106113
Margin="4,0,0,0"

src/Views/DiffView.axaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
</Border>
3131

3232
<!-- Title -->
33-
<TextBlock Grid.Column="2" Classes="primary" Margin="4,0,0,0" Text="{Binding Title}" FontSize="11" TextTrimming="CharacterEllipsis"/>
33+
<TextBlock Grid.Column="2" Classes="primary" Margin="4,0,0,0" Text="{Binding Title}" ToolTip.Tip="{Binding Title}" FontSize="11" TextTrimming="CharacterEllipsis"/>
3434

3535
<!-- Toolbar Buttons -->
3636
<StackPanel Grid.Column="3" Margin="8,0,0,0" Orientation="Horizontal" VerticalAlignment="Center">

src/Views/Histories.axaml

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,11 @@
126126
</Grid.ColumnDefinitions>
127127

128128
<!-- Subject & REFS -->
129-
<Border Grid.Column="0" Padding="{Binding Margin}" ClipToBounds="True">
129+
<Border Grid.Column="0"
130+
Padding="{Binding Margin}"
131+
ClipToBounds="True"
132+
Background="Transparent"
133+
ToolTip.Tip="{Binding Subject}">
130134
<Grid ColumnDefinitions="Auto,Auto,*" Margin="2,0,4,0" ClipToBounds="True">
131135
<v:CommitStatusIndicator Grid.Column="0"
132136
CurrentBranch="{Binding $parent[v:Histories].CurrentBranch}"
@@ -159,7 +163,10 @@
159163
</Border>
160164

161165
<!-- Author -->
162-
<Grid Grid.Column="1" ColumnDefinitions="20,*" IsHitTestVisible="False">
166+
<Grid Grid.Column="1"
167+
ColumnDefinitions="20,*"
168+
Background="Transparent"
169+
ToolTip.Tip="{Binding Author}">
163170
<v:Avatar Grid.Column="0"
164171
Width="16" Height="16"
165172
Margin="4,0,0,0"

src/Views/RevisionFiles.axaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
HorizontalOffset="-8" VerticalAlignment="-8">
4747
<Popup.IsOpen>
4848
<MultiBinding Converter="{x:Static BoolConverters.And}">
49-
<Binding Path="RevisionFileSearchSuggestion" Converter="{x:Static c:ListConverters.IsNotNullOrEmpty}}"/>
49+
<Binding Path="RevisionFileSearchSuggestion" Converter="{x:Static c:ListConverters.IsNotNullOrEmpty}"/>
5050
<Binding Path="$parent[Window].IsActive"/>
5151
</MultiBinding>
5252
</Popup.IsOpen>

0 commit comments

Comments
 (0)