code_review: PR #1478

- Style for `ContentPresenter` in `ItemsControl.Styles` also overrides the default style of TextBox
- Use simple for-each-loop instead of Linq expr

Signed-off-by: leo <[email protected]>

Author: love-linger

src/Views/ExecuteCustomAction.axaml

@@ -56,12 +56,6 @@
 
     <ItemsControl IsVisible="{Binding ControlParameters, Converter={x:Static c:ListConverters.IsNotNullOrEmpty}}"
                   ItemsSource="{Binding ControlParameters, Mode=OneWay}">
-      <ItemsControl.Styles>
-        <Style Selector="ContentPresenter">
-          <Setter Property="Margin" Value="0,1,0,1"/>
-        </Style>
-      </ItemsControl.Styles>
-
       <ItemsControl.ItemsPanel>
         <ItemsPanelTemplate>
           <StackPanel Orientation="Vertical"/>
@@ -70,7 +64,7 @@
 
       <ItemsControl.DataTemplates>
         <DataTemplate DataType="vm:CustomActionControlTextBox">
-          <Grid ColumnDefinitions="150,*">
+          <Grid Height="32" ColumnDefinitions="150,*">
             <TextBlock Grid.Column="0"
                        Text="{Binding Label}"
                        HorizontalAlignment="Right" VerticalAlignment="Center"
@@ -85,7 +79,7 @@
         </DataTemplate>
 
         <DataTemplate DataType="vm:CustomActionControlCheckBox">
-          <Grid ColumnDefinitions="150,*">
+          <Grid Height="32" ColumnDefinitions="150,*">
             <CheckBox Grid.Column="1"
                       Content="{Binding Label}"
                       ToolTip.Tip="{Binding ToolTip, Mode=OneWay}"
@@ -94,7 +88,7 @@
         </DataTemplate>
 
         <DataTemplate DataType="vm:CustomActionControlPathSelector">
-          <Grid ColumnDefinitions="150,*">
+          <Grid Height="32" ColumnDefinitions="150,*">
             <TextBlock Grid.Column="0"
                        Text="{Binding Label}"
                        HorizontalAlignment="Right" VerticalAlignment="Center"

src/Views/ExecuteCustomAction.axaml.cs

@@ -1,5 +1,5 @@
 using System;
-using System.Linq;
+
 using Avalonia.Controls;
 using Avalonia.Input;
 using Avalonia.Interactivity;
@@ -17,11 +17,15 @@ public ExecuteCustomAction()
 
         private void OnLoaded(object sender, RoutedEventArgs e)
         {
-            var firstFocusable = this
-                .GetVisualDescendants()
-                .OfType<InputElement>()
-                .FirstOrDefault(x => x.Focusable && x.IsTabStop);
-            firstFocusable?.Focus();
+            var inputs = this.GetVisualDescendants();
+            foreach (var input in inputs)
+            {
+                if (input is InputElement { Focusable: true, IsTabStop: true } focusable)
+                {
+                    focusable.Focus();
+                    return;
+                }
+            }
         }
 
         private async void SelectPath(object sender, RoutedEventArgs e)