A kind of a single instance mode

only first launched instance creates system tray icon and does not quit

Author: wl2776

src/App.axaml.cs

@@ -169,9 +169,9 @@ public static void SetTheme(string theme, string themeOverridesFile)
             }
         }
 
-        public static void SetupTrayIcon(bool enable)
+        public void SetupTrayIcon(bool enable)
         {
-            if (enable)
+            if (enable && Native.OS.EnsureSingleInstance())
             {
                 var icons = new TrayIcons {
                     new TrayIcon {
@@ -186,6 +186,7 @@ public static void SetupTrayIcon(bool enable)
                 };
                 icons[0].Clicked += (_, _) => ToggleWindow();
                 TrayIcon.SetIcons(Current, icons);
+                _createdSystemTrayIcon = true;
             }
         }
 
@@ -519,11 +520,11 @@ private void TryLaunchedAsNormal(IClassicDesktopStyleApplicationLifetime desktop
                 startupRepo = desktop.Args[0];
 
             var pref = ViewModels.Preference.Instance;
-            if (pref.SystemTrayIcon) {
+            if (_createdSystemTrayIcon) {
                 desktop.ShutdownMode = ShutdownMode.OnExplicitShutdown;
             }
 
-            _launcher = new ViewModels.Launcher(startupRepo);
+            _launcher = new ViewModels.Launcher(startupRepo, _createdSystemTrayIcon);
             desktop.MainWindow = new Views.Launcher() { DataContext = _launcher };
 
 #if !DISABLE_UPDATE_DETECTION
@@ -589,5 +590,6 @@ private void ShowSelfUpdateResult(object data)
         private ResourceDictionary _activeLocale = null;
         private ResourceDictionary _themeOverrides = null;
         private ResourceDictionary _fontsOverrides = null;
+        private bool _createdSystemTrayIcon = false;
     }
 }

src/Native/Linux.cs

@@ -11,6 +11,7 @@ namespace SourceGit.Native
     [SupportedOSPlatform("linux")]
     internal class Linux : OS.IBackend
     {
+        private FileStream _fs = null;
         public void SetupApp(AppBuilder builder)
         {
             builder.With(new X11PlatformOptions() { EnableIme = true });
@@ -97,6 +98,26 @@ public void OpenWithDefaultEditor(string file)
             }
         }
 
+        public bool EnsureSingleInstance()
+        {
+            var pidfile = Path.Combine(Path.GetTempPath(), "sourcegit.pid");
+            var pid = Process.GetCurrentProcess().Id.ToString();
+            Console.WriteLine("pid " + pid);
+
+            try
+            {
+                _fs = File.OpenWrite(pidfile);
+                _fs.Lock(0, 1000);
+                new StreamWriter(_fs).Write(pid);
+                return true;
+            }
+            catch (IOException)
+            {
+                Console.WriteLine("another SourceGit is running");
+                return false;
+            }
+        }
+        
         private string FindExecutable(string filename)
         {
             var pathVariable = Environment.GetEnvironmentVariable("PATH") ?? string.Empty;

src/Native/MacOS.cs

@@ -86,5 +86,7 @@ public void OpenWithDefaultEditor(string file)
         {
             Process.Start("open", $"\"{file}\"");
         }
+
+        public bool EnsureSingleInstance() { return true; }
     }
 }

src/Native/OS.cs

@@ -21,6 +21,8 @@ public interface IBackend
             void OpenInFileManager(string path, bool select);
             void OpenBrowser(string url);
             void OpenWithDefaultEditor(string file);
+
+            bool EnsureSingleInstance();
         }
 
         public static string DataDir { get; private set; } = string.Empty;
@@ -123,6 +125,11 @@ public static void OpenWithDefaultEditor(string file)
             _backend.OpenWithDefaultEditor(file);
         }
 
+        public static bool EnsureSingleInstance()
+        {
+            return _backend.EnsureSingleInstance();
+        }
+
         private static IBackend _backend = null;
     }
 }

src/Native/Windows.cs

@@ -14,6 +14,8 @@ namespace SourceGit.Native
     [SupportedOSPlatform("windows")]
     internal class Windows : OS.IBackend
     {
+        private FileStream _fs = null;
+        
         [StructLayout(LayoutKind.Sequential)]
         internal struct RTL_OSVERSIONINFOEX
         {
@@ -393,5 +395,25 @@ private string FindVSSolutionFile(DirectoryInfo dir, int leftDepth)
 
             return null;
         }
+
+        public bool EnsureSingleInstance()
+        {
+            var pidfile = Path.Combine(Path.GetTempPath(), "sourcegit.pid");
+            var pid = Process.GetCurrentProcess().Id.ToString();
+            Console.WriteLine("pid " + pid);
+
+            try
+            {
+                _fs = File.OpenWrite(pidfile);
+                _fs.Lock(0, 1000);
+                new StreamWriter(_fs).Write(pid);
+                return true;
+            }
+            catch (IOException)
+            {
+                Console.WriteLine("another SourceGit is running");
+                return false;
+            }
+        }
     }
 }

src/ViewModels/Launcher.cs

@@ -29,6 +29,8 @@ public Workspace ActiveWorkspace
             private set => SetProperty(ref _activeWorkspace, value);
         }
 
+        public bool InterceptQuit { get; } = false;
+
         public LauncherPage ActivePage
         {
             get => _activePage;
@@ -44,9 +46,10 @@ public LauncherPage ActivePage
             }
         }
 
-        public Launcher(string startupRepo)
+        public Launcher(string startupRepo, bool interceptClosing)
         {
             _ignoreIndexChange = true;
+            InterceptQuit = interceptClosing;
 
             Pages = new AvaloniaList<LauncherPage>();
             AddNewTab();

src/Views/Launcher.axaml.cs

@@ -256,11 +256,12 @@ protected override void OnKeyUp(KeyEventArgs e)
         protected override void OnClosing(WindowClosingEventArgs e)
         {
             var pref = ViewModels.Preference.Instance;
-            if (pref.SystemTrayIcon) {
+            var launcher = DataContext as ViewModels.Launcher;
+            if (pref.SystemTrayIcon && launcher is { InterceptQuit: true }) {
                 e.Cancel = true;
                 Hide();
             } else {
-                (DataContext as ViewModels.Launcher)?.Quit(Width, Height);
+                launcher?.Quit(Width, Height);
             }
             base.OnClosing(e);
         }