Skip to content

Commit 8b3d129

Browse files
committed
code_review: PR #711
* SourceGit.Commands.* should not reference code in SourceGit.ViewModels. Signed-off-by: leo <[email protected]>
1 parent 309db6e commit 8b3d129

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

src/Commands/Statistics.cs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,14 @@
11
using System;
2-
using SourceGit.ViewModels;
32

43
namespace SourceGit.Commands
54
{
65
public class Statistics : Command
76
{
8-
public Statistics(string repo)
7+
public Statistics(string repo, int max)
98
{
109
WorkingDirectory = repo;
1110
Context = repo;
12-
Args = $"log --date-order --branches --remotes -{Preference.Instance.MaxHistoryCommits} --pretty=format:\"%ct$%aN\"";
11+
Args = $"log --date-order --branches --remotes -{max} --pretty=format:\"%ct$%aN\"";
1312
}
1413

1514
public Models.Statistics Result()

src/Models/Statistics.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
using System;
22
using System.Collections.Generic;
33
using System.Globalization;
4+
45
using LiveChartsCore;
56
using LiveChartsCore.Defaults;
67
using LiveChartsCore.SkiaSharpView;
@@ -138,7 +139,8 @@ public class Statistics
138139
public Statistics()
139140
{
140141
_today = DateTime.Now.ToLocalTime().Date;
141-
_thisWeekStart = _today.AddDays(((int)_today.DayOfWeek + (int)CultureInfo.CurrentCulture.DateTimeFormat.FirstDayOfWeek) % 7 - 7);
142+
var weekOffset = (7 + (int)_today.DayOfWeek - (int)CultureInfo.CurrentCulture.DateTimeFormat.FirstDayOfWeek) % 7;
143+
_thisWeekStart = _today.AddDays(-weekOffset);
142144
_thisMonthStart = _today.AddDays(1 - _today.Day);
143145

144146
All = new StatisticsReport(StaticsticsMode.All, DateTime.MinValue);

src/ViewModels/Statistics.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public Statistics(string repo)
5454
{
5555
Task.Run(() =>
5656
{
57-
var result = new Commands.Statistics(repo).Result();
57+
var result = new Commands.Statistics(repo, Preference.Instance.MaxHistoryCommits).Result();
5858
Dispatcher.UIThread.Invoke(() =>
5959
{
6060
_data = result;

0 commit comments

Comments
 (0)