code_review: PR #956

* Just use `Check` instead of a new one `AutoCheck`

Signed-off-by: leo <[email protected]>

Author: love-linger

src/ViewModels/LauncherPage.cs

@@ -59,17 +59,15 @@ public bool CanCreatePopup()
         public void StartPopup(Popup popup)
         {
             Popup = popup;
-            ProcessPopup(true);
+            ProcessPopup();
         }
 
-        public async void ProcessPopup(bool autoCheck = false)
+        public async void ProcessPopup()
         {
             if (_popup != null)
             {
                 if (!_popup.Check())
                     return;
-                if (autoCheck && !_popup.AutoCheck())
-                    return;
 
                 _popup.InProgress = true;
                 var task = _popup.Sure();

src/ViewModels/Popup.cs

@@ -29,19 +29,14 @@ public string ProgressDescription
         }
 
         [UnconditionalSuppressMessage("AssemblyLoadTrimming", "IL2026:RequiresUnreferencedCode")]
-        public bool Check()
+        public virtual bool Check()
         {
             if (HasErrors)
                 return false;
             ValidateAllProperties();
             return !HasErrors;
         }
 
-        public virtual bool AutoCheck()
-        {
-            return true;
-        }
-
         public virtual Task<bool> Sure()
         {
             return null;

src/ViewModels/Push.cs

@@ -152,9 +152,9 @@ public Push(Repository repo, Models.Branch localBranch)
             View = new Views.Push() { DataContext = this };
         }
 
-        public override bool AutoCheck()
+        public override bool Check()
         {
-            return !string.IsNullOrEmpty(_selectedRemoteBranch?.Head);
+            return base.Check() && !string.IsNullOrEmpty(_selectedRemoteBranch?.Head);
         }
 
         public override Task<bool> Sure()