Skip to content

Commit 9d9dd6a

Browse files
committed
code_review: PR #160
* should be `Icons.Copy` not `Icon.Copy` * remove unused using * keep the same code style in a function
1 parent 04e6ed4 commit 9d9dd6a

File tree

3 files changed

+27
-22
lines changed

3 files changed

+27
-22
lines changed

src/ViewModels/CommitDetail.cs

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
using Avalonia.Threading;
1111

1212
using CommunityToolkit.Mvvm.ComponentModel;
13-
using SourceGit.Models;
1413

1514
namespace SourceGit.ViewModels
1615
{
@@ -219,17 +218,17 @@ public ContextMenu CreateChangeContextMenu(Models.Change change)
219218
ev.Handled = true;
220219
};
221220
menu.Items.Add(copyPath);
222-
var copyFileName = new MenuItem()
223-
{
224-
Header = App.Text("CopyFileName"),
225-
Icon = App.CreateMenuIcon("Icon.Copy"),
226-
};
221+
222+
var copyFileName = new MenuItem();
223+
copyFileName.Header = App.Text("CopyFileName");
224+
copyFileName.Icon = App.CreateMenuIcon("Icons.Copy");
227225
copyFileName.Click += (_, e) =>
228226
{
229227
App.CopyText(Path.GetFileName(change.Path));
230228
e.Handled = true;
231229
};
232230
menu.Items.Add(copyFileName);
231+
233232
return menu;
234233
}
235234

@@ -295,11 +294,9 @@ public ContextMenu CreateRevisionFileContextMenu(Models.Object file)
295294
ev.Handled = true;
296295
};
297296

298-
var copyFileName = new MenuItem()
299-
{
300-
Header = App.Text("CopyFileName"),
301-
Icon = App.CreateMenuIcon("Icon.Copy"),
302-
};
297+
var copyFileName = new MenuItem();
298+
copyFileName.Header = App.Text("CopyFileName");
299+
copyFileName.Icon = App.CreateMenuIcon("Icons.Copy");
303300
copyFileName.Click += (_, e) =>
304301
{
305302
App.CopyText(Path.GetFileName(file.Path));

src/ViewModels/RevisionCompare.cs

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -181,19 +181,18 @@ public ContextMenu CreateChangeContextMenu()
181181
App.CopyText(change.Path);
182182
ev.Handled = true;
183183
};
184-
185184
menu.Items.Add(copyPath);
186-
var copyFileName = new MenuItem()
187-
{
188-
Header = App.Text("CopyFileName"),
189-
Icon = App.CreateMenuIcon("Icon.Copy"),
190-
};
185+
186+
var copyFileName = new MenuItem();
187+
copyFileName.Header = App.Text("CopyFileName");
188+
copyFileName.Icon = App.CreateMenuIcon("Icons.Copy");
191189
copyFileName.Click += (_, e) =>
192190
{
193191
App.CopyText(Path.GetFileName(change.Path));
194192
e.Handled = true;
195193
};
196194
menu.Items.Add(copyFileName);
195+
197196
return menu;
198197
}
199198

src/ViewModels/WorkingCopy.cs

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -584,11 +584,10 @@ public ContextMenu CreateContextMenuForUnstagedChanges()
584584
e.Handled = true;
585585
};
586586
menu.Items.Add(copy);
587-
var copyFileName = new MenuItem()
588-
{
589-
Header = App.Text("CopyFileName"),
590-
Icon = App.CreateMenuIcon("Icon.Copy"),
591-
};
587+
588+
var copyFileName = new MenuItem();
589+
copyFileName.Header = App.Text("CopyFileName");
590+
copyFileName.Icon = App.CreateMenuIcon("Icons.Copy");
592591
copyFileName.Click += (_, e) =>
593592
{
594593
App.CopyText(Path.GetFileName(change.Path));
@@ -801,6 +800,15 @@ public ContextMenu CreateContextMenuForStagedChanges()
801800
App.CopyText(change.Path);
802801
e.Handled = true;
803802
};
803+
804+
var copyFileName = new MenuItem();
805+
copyFileName.Header = App.Text("CopyFileName");
806+
copyFileName.Icon = App.CreateMenuIcon("Icons.Copy");
807+
copyFileName.Click += (_, e) =>
808+
{
809+
App.CopyText(Path.GetFileName(change.Path));
810+
e.Handled = true;
811+
};
804812

805813
menu.Items.Add(explore);
806814
menu.Items.Add(openWith);
@@ -811,6 +819,7 @@ public ContextMenu CreateContextMenuForStagedChanges()
811819
menu.Items.Add(patch);
812820
menu.Items.Add(new MenuItem() { Header = "-" });
813821
menu.Items.Add(copyPath);
822+
menu.Items.Add(copyFileName);
814823
}
815824
else
816825
{

0 commit comments

Comments
 (0)