Skip to content

Commit 9f1d77d

Browse files
committed
ux: commit base info layout
Signed-off-by: leo <[email protected]>
1 parent 1a4fae7 commit 9f1d77d

File tree

5 files changed

+18
-17
lines changed

5 files changed

+18
-17
lines changed

src/Views/CommitBaseInfo.axaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<!-- Author -->
1818
<Grid ColumnDefinitions="96,*">
1919
<v:Avatar Grid.Column="0" Width="64" Height="64" HorizontalAlignment="Right" User="{Binding Author}"/>
20-
<StackPanel Grid.Column="1" Margin="16,0,8,0" Orientation="Vertical">
20+
<StackPanel Grid.Column="1" Margin="16,0,4,0" Orientation="Vertical">
2121
<TextBlock Classes="group_header_label" Text="{DynamicResource Text.CommitDetail.Info.Author}"/>
2222
<Border Margin="0,10,0,8" Background="Transparent" ToolTip.Tip="{Binding Author}" Tag="{Binding Author}" ContextRequested="OnUserContextRequested">
2323
<TextBlock Foreground="{DynamicResource Brush.FG2}" TextTrimming="CharacterEllipsis">
@@ -35,7 +35,7 @@
3535
<!-- Committer -->
3636
<Grid ColumnDefinitions="96,*" IsVisible="{Binding IsCommitterVisible}">
3737
<v:Avatar Grid.Column="0" Width="64" Height="64" HorizontalAlignment="Right" User="{Binding Committer}"/>
38-
<StackPanel Grid.Column="1" Margin="16,0,8,0" Orientation="Vertical">
38+
<StackPanel Grid.Column="1" Margin="16,0,4,0" Orientation="Vertical">
3939
<TextBlock Classes="group_header_label" Text="{DynamicResource Text.CommitDetail.Info.Committer}"/>
4040
<Border Margin="0,10,0,8" Background="Transparent" ToolTip.Tip="{Binding Committer}" Tag="{Binding Committer}" ContextRequested="OnUserContextRequested">
4141
<TextBlock Foreground="{DynamicResource Brush.FG2}" TextTrimming="CharacterEllipsis">
@@ -52,7 +52,7 @@
5252
</UniformGrid>
5353

5454
<!-- Line -->
55-
<Rectangle Height=".65" Margin="8" Fill="{DynamicResource Brush.Border2}" VerticalAlignment="Center"/>
55+
<Rectangle Height=".65" Margin="8,8,0,8" Fill="{DynamicResource Brush.Border2}" VerticalAlignment="Center"/>
5656

5757
<!-- Base Information -->
5858
<Grid RowDefinitions="24,Auto,Auto,Auto,Auto" ColumnDefinitions="96,*">
@@ -196,7 +196,7 @@
196196
<!-- Messages -->
197197
<TextBlock Grid.Row="4" Grid.Column="0" Classes="info_label" VerticalAlignment="Top" Margin="0,4,0,0" Text="{DynamicResource Text.CommitDetail.Info.Message}" />
198198
<v:CommitMessagePresenter Grid.Row="4" Grid.Column="1"
199-
Margin="12,4,8,0"
199+
Margin="12,4,0,0"
200200
FullMessage="{Binding #ThisControl.FullMessage}"
201201
HorizontalAlignment="Stretch"
202202
TextWrapping="Wrap">

src/Views/CommitDetail.axaml

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,29 +9,30 @@
99
mc:Ignorable="d" d:DesignWidth="800" d:DesignHeight="450"
1010
x:Class="SourceGit.Views.CommitDetail"
1111
x:DataType="vm:CommitDetail">
12-
<TabControl SelectedIndex="{Binding ActiveTabIndex, Mode=TwoWay}" Padding="4">
12+
<TabControl SelectedIndex="{Binding ActiveTabIndex, Mode=TwoWay}" Padding="0,4">
1313
<!-- Information Page -->
1414
<TabItem>
1515
<TabItem.Header>
1616
<TextBlock Classes="tab_header" Text="{DynamicResource Text.CommitDetail.Info}"/>
1717
</TabItem.Header>
1818

19-
<ScrollViewer Offset="{Binding ScrollOffset, Mode=TwoWay}" HorizontalScrollBarVisibility="Disabled" VerticalScrollBarVisibility="Auto">
19+
<ScrollViewer Margin="4,0,0,0" Offset="{Binding ScrollOffset, Mode=TwoWay}" HorizontalScrollBarVisibility="Disabled" VerticalScrollBarVisibility="Auto">
2020
<StackPanel Orientation="Vertical">
2121
<!-- Base Information -->
2222
<v:CommitBaseInfo Content="{Binding Commit}"
2323
FullMessage="{Binding FullMessage}"
2424
SignInfo="{Binding SignInfo}"
2525
SupportsContainsIn="True"
2626
WebLinks="{Binding WebLinks}"
27-
Children="{Binding Children}"/>
27+
Children="{Binding Children}"
28+
Margin="0,0,12,0"/>
2829

2930
<!-- Line -->
30-
<Rectangle Height=".65" Margin="8" Fill="{DynamicResource Brush.Border2}"/>
31+
<Rectangle Height=".65" Margin="8,8,12,8" Fill="{DynamicResource Brush.Border2}"/>
3132

3233
<!-- Change List -->
3334
<ListBox Background="Transparent"
34-
Margin="64,0,8,4"
35+
Margin="64,0,12,4"
3536
SelectionMode="Single"
3637
ItemsSource="{Binding Changes, Converter={x:Static c:ListConverters.Top100Changes}}"
3738
KeyDown="OnCommitListKeyDown">
@@ -72,7 +73,7 @@
7273
</ListBox>
7374

7475
<!-- Only Top100 Tip -->
75-
<TextBlock Margin="108,0,0,16"
76+
<TextBlock Margin="108,0,12,16"
7677
Text="{DynamicResource Text.CommitDetail.Info.GotoChangesPage}"
7778
Foreground="{DynamicResource Brush.FG2}"
7879
IsVisible="{Binding Changes, Converter={x:Static c:ListConverters.IsOnlyTop100Shows}}"/>
@@ -84,14 +85,14 @@
8485
<TabItem.Header>
8586
<TextBlock Classes="tab_header" Text="{DynamicResource Text.CommitDetail.Changes}"/>
8687
</TabItem.Header>
87-
<v:CommitChanges/>
88+
<v:CommitChanges Margin="4,0"/>
8889
</TabItem>
8990

9091
<TabItem>
9192
<TabItem.Header>
9293
<TextBlock Classes="tab_header" Text="{DynamicResource Text.CommitDetail.Files}"/>
9394
</TabItem.Header>
94-
<v:RevisionFiles/>
95+
<v:RevisionFiles Margin="4,0"/>
9596
</TabItem>
9697
</TabControl>
9798
</UserControl>

src/Views/DiffView.axaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@
270270
<ContentControl.DataTemplates>
271271
<DataTemplate DataType="m:RevisionSubmodule">
272272
<Border Margin="0,0,0,8" BorderThickness="1" BorderBrush="{DynamicResource Brush.Border1}" Background="{DynamicResource Brush.Window}">
273-
<v:CommitBaseInfo MaxHeight="256" Margin="0,0,0,4" Content="{Binding Commit}" FullMessage="{Binding FullMessage}"/>
273+
<v:CommitBaseInfo MaxHeight="256" Margin="0,4,8,6" Content="{Binding Commit}" FullMessage="{Binding FullMessage}"/>
274274
</Border>
275275
</DataTemplate>
276276
</ContentControl.DataTemplates>
@@ -294,7 +294,7 @@
294294
<ContentControl Content="{Binding New}">
295295
<ContentControl.DataTemplates>
296296
<DataTemplate DataType="m:RevisionSubmodule">
297-
<v:CommitBaseInfo MaxHeight="256" Margin="0,0,0,4" Content="{Binding Commit}" FullMessage="{Binding FullMessage}"/>
297+
<v:CommitBaseInfo MaxHeight="256" Margin="0,4,8,6" Content="{Binding Commit}" FullMessage="{Binding FullMessage}"/>
298298
</DataTemplate>
299299
</ContentControl.DataTemplates>
300300
</ContentControl>

src/Views/DirHistories.axaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@
120120
BorderBrush="{DynamicResource Brush.Border0}"/>
121121

122122
<!-- Commit Detail -->
123-
<Border Grid.Column="2" Padding="0,4,4,8" IsVisible="{Binding !IsLoading}">
123+
<Border Grid.Column="2" Padding="0,4" IsVisible="{Binding !IsLoading}">
124124
<ContentControl Content="{Binding Detail, Mode=OneWay}">
125125
<ContentControl.DataTemplates>
126126
<DataTemplate DataType="vm:CommitDetail">

src/Views/RevisionFileContentViewer.axaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,10 +60,10 @@
6060
</DataTemplate>
6161

6262
<DataTemplate DataType="m:RevisionSubmodule">
63-
<Grid RowDefinitions="Auto,*" Margin="8,0">
63+
<Grid RowDefinitions="Auto,*">
6464
<TextBlock Grid.Row="0" Margin="0,8,0,0" Text="{DynamicResource Text.CommitDetail.Files.Submodule}" FontSize="18" FontWeight="Bold" HorizontalAlignment="Center" Foreground="{DynamicResource Brush.FG2}"/>
6565
<ScrollViewer Grid.Row="1" Margin="0,16,0,0" HorizontalScrollBarVisibility="Disabled" VerticalScrollBarVisibility="Auto">
66-
<v:CommitBaseInfo Content="{Binding Commit}" FullMessage="{Binding FullMessage}"/>
66+
<v:CommitBaseInfo Content="{Binding Commit}" Margin="4,0,12,0" FullMessage="{Binding FullMessage}"/>
6767
</ScrollViewer>
6868
</Grid>
6969
</DataTemplate>

0 commit comments

Comments
 (0)