code_style: move hardcoded brush/strings (for outlier Conflict-icon) into named constants (#1350)

This makes code more consistent and gives better overview of all the icons.
(Potentially, this special/outlier icon could be moved into the existing arrays as an extra ChangeState enum-value.)

Author: goran-w

src/Views/ChangeStatusIcon.cs

@@ -64,6 +64,10 @@ public class ChangeStatusIcon : Control
         private static readonly string[] INDICATOR = ["?", "±", "T", "+", "−", "➜", "❏", "U", "★"];
         private static readonly string[] TIPS = ["Unknown", "Modified", "Type Changed", "Added", "Deleted", "Renamed", "Copied", "Unmerged", "Untracked"];
 
+        private static readonly IBrush BACKGROUND_CONFLICT = Brushes.OrangeRed;
+        private const string INDICATOR_CONFLICT = "!";
+        private const string TIP_CONFLICT = "Conflict";
+
         public static readonly StyledProperty<bool> IsUnstagedChangeProperty =
             AvaloniaProperty.Register<ChangeStatusIcon, bool>(nameof(IsUnstagedChange));
 
@@ -95,8 +99,8 @@ public override void Render(DrawingContext context)
             {
                 if (Change.IsConflict)
                 {
-                    background = Brushes.OrangeRed;
-                    indicator = "!";
+                    background = BACKGROUND_CONFLICT;
+                    indicator = INDICATOR_CONFLICT;
                 }
                 else
                 {
@@ -139,7 +143,7 @@ protected override void OnPropertyChanged(AvaloniaPropertyChangedEventArgs chang
                 }
 
                 if (isUnstaged)
-                    ToolTip.SetTip(this, c.IsConflict ? "Conflict" : TIPS[(int)c.WorkTree]);
+                    ToolTip.SetTip(this, c.IsConflict ? TIP_CONFLICT : TIPS[(int)c.WorkTree]);
                 else
                     ToolTip.SetTip(this, TIPS[(int)c.Index]);