code_review: PR #1103

Since we only use `$GIT_COMMON_DIR` in filesystem watcher, it is unnecessary to store this value in `Repository`, and we can query the `$GIT_COMMON_DIR` only when it looks like a worktree

Signed-off-by: leo <[email protected]>

Author: love-linger

src/Models/IRepository.cs

@@ -3,8 +3,7 @@
     public interface IRepository
     {
         string FullPath { get; set; }
-        string GitDir { get; set; }
-        string GitCommonDir { get; set; }
+        string GitDirForWatcher { get; }
 
         void RefreshBranches();
         void RefreshWorktrees();

src/Models/Watcher.cs

@@ -23,11 +23,8 @@ public Watcher(IRepository repo)
             _wcWatcher.Deleted += OnWorkingCopyChanged;
             _wcWatcher.EnableRaisingEvents = true;
 
-            // If this repository is a worktree repository, just watch the main repository's gitdir.
-            var repoWatchDir = _repo.GitCommonDir.Replace("\\", "/");
-
             _repoWatcher = new FileSystemWatcher();
-            _repoWatcher.Path = repoWatchDir;
+            _repoWatcher.Path = _repo.GitDirForWatcher;
             _repoWatcher.Filter = "*";
             _repoWatcher.NotifyFilter = NotifyFilters.LastWrite | NotifyFilters.DirectoryName | NotifyFilters.FileName;
             _repoWatcher.IncludeSubdirectories = true;

src/ViewModels/Launcher.cs

@@ -282,7 +282,6 @@ public void OpenRepositoryInTab(RepositoryNode node, LauncherPage page)
 
             var isBare = new Commands.IsBareRepository(node.Id).Result();
             var gitDir = node.Id;
-            var gitCommonDir = gitDir;
             if (!isBare)
             {
                 gitDir = new Commands.QueryGitDir(node.Id).Result();
@@ -292,12 +291,9 @@ public void OpenRepositoryInTab(RepositoryNode node, LauncherPage page)
                     App.RaiseException(ctx, "Given path is not a valid git repository!");
                     return;
                 }
-                gitCommonDir = new Commands.QueryGitCommonDir(node.Id).Result();
-                if (string.IsNullOrEmpty(gitCommonDir))
-                    gitCommonDir = gitDir;
             }
 
-            var repo = new Repository(isBare, node.Id, gitDir, gitCommonDir);
+            var repo = new Repository(isBare, node.Id, gitDir);
             repo.Open();
 
             if (page == null)

src/ViewModels/Repository.cs

@@ -45,10 +45,19 @@ public string GitDir
             set => SetProperty(ref _gitDir, value);
         }
 
-        public string GitCommonDir
+        public string GitDirForWatcher
         {
-            get => _gitCommonDir;
-            set => SetProperty(ref _gitCommonDir, value);
+            get
+            {
+                // Only try to get `$GIT_COMMON_DIR` if this repository looks like a worktree.
+                if (_gitDir.Replace("\\", "/").IndexOf(".git/worktrees/", StringComparison.Ordinal) > 0)
+                {
+                    var commonDir = new Commands.QueryGitCommonDir(_fullpath).Result();
+                    return string.IsNullOrEmpty(commonDir) ? _gitDir : commonDir;
+                }
+
+                return _gitDir;
+            }
         }
 
         public Models.RepositorySettings Settings
@@ -435,12 +444,11 @@ public int CommitDetailActivePageIndex
             set;
         } = 0;
 
-        public Repository(bool isBare, string path, string gitDir, string gitCommonDir)
+        public Repository(bool isBare, string path, string gitDir)
         {
             IsBare = isBare;
             FullPath = path;
             GitDir = gitDir;
-            GitCommonDir = gitCommonDir;
         }
 
         public void Open()
@@ -2444,7 +2452,6 @@ private void AutoFetchImpl(object sender)
 
         private string _fullpath = string.Empty;
         private string _gitDir = string.Empty;
-        private string _gitCommonDir = string.Empty;
         private Models.RepositorySettings _settings = null;
         private Models.FilterMode _historiesFilterMode = Models.FilterMode.None;
         private bool _hasAllowedSignersFile = false;