refactor: re-write commit searching (part 3)

Signed-off-by: leo <[email protected]>

Author: love-linger

src/Commands/QueryRevisionFileNames.cs

@@ -1,4 +1,6 @@
-namespace SourceGit.Commands
+using System.Collections.Generic;
+
+namespace SourceGit.Commands
 {
     public class QueryRevisionFileNames : Command
     {
@@ -9,13 +11,17 @@ public QueryRevisionFileNames(string repo, string revision)
             Args = $"ls-tree -r -z --name-only {revision}";
         }
 
-        public string[] Result()
+        public List<string> Result()
         {
             var rs = ReadToEnd();
-            if (rs.IsSuccess)
-                return rs.StdOut.Split('\0', System.StringSplitOptions.RemoveEmptyEntries);
+            if (!rs.IsSuccess)
+                return [];
 
-            return [];
+            var lines = rs.StdOut.Split('\0', System.StringSplitOptions.RemoveEmptyEntries);
+            var outs = new List<string>();
+            foreach (var line in lines)
+                outs.Add(line);
+            return outs;
         }
     }
 }

src/ViewModels/CommitDetail.cs

@@ -814,14 +814,11 @@ private void RefreshRevisionSearchSuggestion()
                     Task.Run(() =>
                     {
                         var files = new Commands.QueryRevisionFileNames(_repo.FullPath, sha).Result();
-                        var filesList = new List<string>();
-                        filesList.AddRange(files);
-
                         Dispatcher.UIThread.Invoke(() =>
                         {
                             if (sha == Commit.SHA)
                             {
-                                _revisionFiles = filesList;
+                                _revisionFiles = files;
                                 if (!string.IsNullOrEmpty(_revisionFileSearchFilter))
                                     CalcRevisionFileSearchSuggestion();
                             }

src/ViewModels/Repository.cs

@@ -2376,17 +2376,11 @@ private void CalcWorktreeFilesForSearching()
 
             Task.Run(() =>
             {
-                var files = new Commands.QueryRevisionFileNames(_fullpath, "HEAD").Result();
+                _worktreeFiles = new Commands.QueryRevisionFileNames(_fullpath, "HEAD").Result();
                 Dispatcher.UIThread.Invoke(() =>
                 {
-                    if (!IsSearchingCommitsByFilePath())
-                        return;
-
-                    _worktreeFiles = new List<string>();
-                    foreach (var f in files)
-                        _worktreeFiles.Add(f);
-
-                    CalcMatchedFilesForSearching();
+                    if (IsSearchingCommitsByFilePath())
+                        CalcMatchedFilesForSearching();
                 });
             });
         }