fix: OpenFolderPickerAsync raise exception when selected a drive root such as E:\

love-linger · love-linger · commit bc5deac9fe2f · 2025-05-30T17:12:56.000+08:00
Signed-off-by: leo &lt;longshuang@msn.cn&gt;
diff --git a/src/Commands/FormatPatch.cs b/src/Commands/FormatPatch.cs
@@ -6,6 +6,7 @@ public FormatPatch(string repo, string commit, string saveTo)
         {
             WorkingDirectory = repo;
             Context = repo;
+            Editor = EditorType.None;
             Args = $"format-patch {commit} -1 --output=\"{saveTo}\"";
         }
     }
diff --git a/src/ViewModels/CommitDetail.cs b/src/ViewModels/CommitDetail.cs
@@ -452,7 +452,9 @@ public ContextMenu CreateRevisionFileContextMenu(Models.Object file)
                     var selected = await storageProvider.OpenFolderPickerAsync(options);
                     if (selected.Count == 1)
                     {
-                        var saveTo = Path.Combine(selected[0].Path.LocalPath, Path.GetFileName(file.Path));
+                        var folder = selected[0];
+                        var folderPath = folder is { Path: { IsAbsoluteUri: true } path } ? path.LocalPath : folder?.Path.ToString();
+                        var saveTo = Path.Combine(folderPath, Path.GetFileName(file.Path));
                         Commands.SaveRevisionFile.Run(_repo.FullPath, _commit.SHA, file.Path, saveTo);
                     }
                 }
diff --git a/src/ViewModels/Histories.cs b/src/ViewModels/Histories.cs
@@ -333,10 +333,12 @@ public ContextMenu MakeContextMenu(ListBox list)
                         {
                             log = _repo.CreateLog("Save as Patch");
 
+                            var folder = picker[0];
+                            var folderPath = folder is { Path: { IsAbsoluteUri: true } path } ? path.LocalPath : folder?.Path.ToString();
                             var succ = false;
                             for (var i = 0; i < selected.Count; i++)
                             {
-                                var saveTo = GetPatchFileName(picker[0].Path.LocalPath, selected[i], i);
+                                var saveTo = GetPatchFileName(folderPath, selected[i], i);
                                 succ = await Task.Run(() => new Commands.FormatPatch(_repo.FullPath, selected[i].SHA, saveTo).Use(log).Exec());
                                 if (!succ)
                                     break;
@@ -691,8 +693,10 @@ public ContextMenu MakeContextMenu(ListBox list)
                     {
                         log = _repo.CreateLog("Save as Patch");
 
-                        var saveTo = GetPatchFileName(selected[0].Path.LocalPath, commit);
-                        var succ = new Commands.FormatPatch(_repo.FullPath, commit.SHA, saveTo).Use(log).Exec();
+                        var folder = selected[0];
+                        var folderPath = folder is { Path: { IsAbsoluteUri: true } path } ? path.LocalPath : folder?.Path.ToString();
+                        var saveTo = GetPatchFileName(folderPath, commit);
+                        var succ = await Task.Run(() => new Commands.FormatPatch(_repo.FullPath, commit.SHA, saveTo).Use(log).Exec());
                         if (succ)
                             App.SendNotification(_repo.FullPath, App.Text("SaveAsPatchSuccess"));
                     }
diff --git a/src/Views/AddWorktree.axaml.cs b/src/Views/AddWorktree.axaml.cs
@@ -23,7 +23,11 @@ private async void SelectLocation(object _, RoutedEventArgs e)
             {
                 var selected = await toplevel.StorageProvider.OpenFolderPickerAsync(options);
                 if (selected.Count == 1)
-                    TxtLocation.Text = selected[0].Path.LocalPath;
+                {
+                    var folder = selected[0];
+                    var folderPath = folder is { Path: { IsAbsoluteUri: true } path } ? path.LocalPath : folder?.Path.ToString();
+                    TxtLocation.Text = folderPath;
+                }
             }
             catch (Exception exception)
             {
diff --git a/src/Views/Clone.axaml.cs b/src/Views/Clone.axaml.cs
@@ -23,7 +23,11 @@ private async void SelectParentFolder(object _, RoutedEventArgs e)
             {
                 var selected = await toplevel.StorageProvider.OpenFolderPickerAsync(options);
                 if (selected.Count == 1)
-                    TxtParentFolder.Text = selected[0].Path.LocalPath;
+                {
+                    var folder = selected[0];
+                    var folderPath = folder is { Path: { IsAbsoluteUri: true } path } ? path.LocalPath : folder?.Path.ToString();
+                    TxtParentFolder.Text = folderPath;
+                }
             }
             catch (Exception exception)
             {
diff --git a/src/Views/ConfigureWorkspace.axaml.cs b/src/Views/ConfigureWorkspace.axaml.cs
@@ -32,7 +32,9 @@ private async void SelectDefaultCloneDir(object _, RoutedEventArgs e)
                 var selected = await StorageProvider.OpenFolderPickerAsync(options);
                 if (selected.Count == 1)
                 {
-                    workspace.Selected.DefaultCloneDir = selected[0].Path.LocalPath;
+                    var folder = selected[0];
+                    var folderPath = folder is { Path: { IsAbsoluteUri: true } path } ? path.LocalPath : folder?.Path.ToString();
+                    workspace.Selected.DefaultCloneDir = folderPath;
                 }
             }
             catch (Exception ex)
diff --git a/src/Views/Preferences.axaml.cs b/src/Views/Preferences.axaml.cs
@@ -250,7 +250,9 @@ private async void SelectDefaultCloneDir(object _, RoutedEventArgs e)
                 var selected = await StorageProvider.OpenFolderPickerAsync(options);
                 if (selected.Count == 1)
                 {
-                    ViewModels.Preferences.Instance.GitDefaultCloneDir = selected[0].Path.LocalPath;
+                    var folder = selected[0];
+                    var folderPath = folder is { Path: { IsAbsoluteUri: true } path } ? path.LocalPath : folder?.Path.ToString();
+                    ViewModels.Preferences.Instance.GitDefaultCloneDir = folderPath;
                 }
             }
             catch (Exception ex)
diff --git a/src/Views/WelcomeToolbar.axaml.cs b/src/Views/WelcomeToolbar.axaml.cs
@@ -35,7 +35,11 @@ private async void OpenLocalRepository(object _1, RoutedEventArgs e)
             {
                 var selected = await topLevel.StorageProvider.OpenFolderPickerAsync(options);
                 if (selected.Count == 1)
-                    ViewModels.Welcome.Instance.OpenOrInitRepository(selected[0].Path.LocalPath, null, false);
+                {
+                    var folder = selected[0];
+                    var folderPath = folder is { Path: { IsAbsoluteUri: true } path } ? path.LocalPath : folder?.Path.ToString();
+                    ViewModels.Welcome.Instance.OpenOrInitRepository(folderPath, null, false);
+                }
             }
             catch (Exception exception)
             {

Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,7 @@ public FormatPatch(string repo, string commit, string saveTo)`
`6`	`6`	`{`
`7`	`7`	`WorkingDirectory = repo;`
`8`	`8`	`Context = repo;`
	`9`	`+ Editor = EditorType.None;`
`9`	`10`	`Args = $"format-patch {commit} -1 --output=\"{saveTo}\"";`
`10`	`11`	`}`
`11`	`12`	`}`
Original file line number	Diff line number	Diff line change
`@@ -452,7 +452,9 @@ public ContextMenu CreateRevisionFileContextMenu(Models.Object file)`
`452`	`452`	`var selected = await storageProvider.OpenFolderPickerAsync(options);`
`453`	`453`	`if (selected.Count == 1)`
`454`	`454`	`{`
`455`		`- var saveTo = Path.Combine(selected[0].Path.LocalPath, Path.GetFileName(file.Path));`
	`455`	`+ var folder = selected[0];`
	`456`	`+ var folderPath = folder is { Path: { IsAbsoluteUri: true } path } ? path.LocalPath : folder?.Path.ToString();`
	`457`	`+ var saveTo = Path.Combine(folderPath, Path.GetFileName(file.Path));`
`456`	`458`	`Commands.SaveRevisionFile.Run(_repo.FullPath, _commit.SHA, file.Path, saveTo);`
`457`	`459`	`}`
`458`	`460`	`}`
Original file line number	Diff line number	Diff line change
`@@ -333,10 +333,12 @@ public ContextMenu MakeContextMenu(ListBox list)`
`333`	`333`	`{`
`334`	`334`	`log = _repo.CreateLog("Save as Patch");`
`335`	`335`
	`336`	`+ var folder = picker[0];`
	`337`	`+ var folderPath = folder is { Path: { IsAbsoluteUri: true } path } ? path.LocalPath : folder?.Path.ToString();`
`336`	`338`	`var succ = false;`
`337`	`339`	`for (var i = 0; i < selected.Count; i++)`
`338`	`340`	`{`
`339`		`- var saveTo = GetPatchFileName(picker[0].Path.LocalPath, selected[i], i);`
	`341`	`+ var saveTo = GetPatchFileName(folderPath, selected[i], i);`
`340`	`342`	`succ = await Task.Run(() => new Commands.FormatPatch(_repo.FullPath, selected[i].SHA, saveTo).Use(log).Exec());`
`341`	`343`	`if (!succ)`
`342`	`344`	`break;`
`@@ -691,8 +693,10 @@ public ContextMenu MakeContextMenu(ListBox list)`
`691`	`693`	`{`
`692`	`694`	`log = _repo.CreateLog("Save as Patch");`
`693`	`695`
`694`		`- var saveTo = GetPatchFileName(selected[0].Path.LocalPath, commit);`
`695`		`- var succ = new Commands.FormatPatch(_repo.FullPath, commit.SHA, saveTo).Use(log).Exec();`
	`696`	`+ var folder = selected[0];`
	`697`	`+ var folderPath = folder is { Path: { IsAbsoluteUri: true } path } ? path.LocalPath : folder?.Path.ToString();`
	`698`	`+ var saveTo = GetPatchFileName(folderPath, commit);`
	`699`	`+ var succ = await Task.Run(() => new Commands.FormatPatch(_repo.FullPath, commit.SHA, saveTo).Use(log).Exec());`
`696`	`700`	`if (succ)`
`697`	`701`	`App.SendNotification(_repo.FullPath, App.Text("SaveAsPatchSuccess"));`
`698`	`702`	`}`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,11 @@ private async void SelectLocation(object _, RoutedEventArgs e)`
`23`	`23`	`{`
`24`	`24`	`var selected = await toplevel.StorageProvider.OpenFolderPickerAsync(options);`
`25`	`25`	`if (selected.Count == 1)`
`26`		`- TxtLocation.Text = selected[0].Path.LocalPath;`
	`26`	`+ {`
	`27`	`+ var folder = selected[0];`
	`28`	`+ var folderPath = folder is { Path: { IsAbsoluteUri: true } path } ? path.LocalPath : folder?.Path.ToString();`
	`29`	`+ TxtLocation.Text = folderPath;`
	`30`	`+ }`
`27`	`31`	`}`
`28`	`32`	`catch (Exception exception)`
`29`	`33`	`{`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,9 @@ private async void SelectDefaultCloneDir(object _, RoutedEventArgs e)`
`32`	`32`	`var selected = await StorageProvider.OpenFolderPickerAsync(options);`
`33`	`33`	`if (selected.Count == 1)`
`34`	`34`	`{`
`35`		`- workspace.Selected.DefaultCloneDir = selected[0].Path.LocalPath;`
	`35`	`+ var folder = selected[0];`
	`36`	`+ var folderPath = folder is { Path: { IsAbsoluteUri: true } path } ? path.LocalPath : folder?.Path.ToString();`
	`37`	`+ workspace.Selected.DefaultCloneDir = folderPath;`
`36`	`38`	`}`
`37`	`39`	`}`
`38`	`40`	`catch (Exception ex)`
Original file line number	Diff line number	Diff line change
`@@ -250,7 +250,9 @@ private async void SelectDefaultCloneDir(object _, RoutedEventArgs e)`
`250`	`250`	`var selected = await StorageProvider.OpenFolderPickerAsync(options);`
`251`	`251`	`if (selected.Count == 1)`
`252`	`252`	`{`
`253`		`- ViewModels.Preferences.Instance.GitDefaultCloneDir = selected[0].Path.LocalPath;`
	`253`	`+ var folder = selected[0];`
	`254`	`+ var folderPath = folder is { Path: { IsAbsoluteUri: true } path } ? path.LocalPath : folder?.Path.ToString();`
	`255`	`+ ViewModels.Preferences.Instance.GitDefaultCloneDir = folderPath;`
`254`	`256`	`}`
`255`	`257`	`}`
`256`	`258`	`catch (Exception ex)`
Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,11 @@ private async void OpenLocalRepository(object _1, RoutedEventArgs e)`
`35`	`35`	`{`
`36`	`36`	`var selected = await topLevel.StorageProvider.OpenFolderPickerAsync(options);`
`37`	`37`	`if (selected.Count == 1)`
`38`		`- ViewModels.Welcome.Instance.OpenOrInitRepository(selected[0].Path.LocalPath, null, false);`
	`38`	`+ {`
	`39`	`+ var folder = selected[0];`
	`40`	`+ var folderPath = folder is { Path: { IsAbsoluteUri: true } path } ? path.LocalPath : folder?.Path.ToString();`
	`41`	`+ ViewModels.Welcome.Instance.OpenOrInitRepository(folderPath, null, false);`
	`42`	`+ }`
`39`	`43`	`}`
`40`	`44`	`catch (Exception exception)`
`41`	`45`	`{`