code_review: PR #1540

- Fix the issue that `StringReader` traits all outputs of `git ls-tree -z` command as a single-line
- Remove unused namespace using

Signed-off-by: leo <[email protected]>

Author: love-linger

src/Commands/QueryRevisionObjects.cs

@@ -14,7 +14,7 @@ public QueryRevisionObjects(string repo, string sha, string parentFolder)
         {
             WorkingDirectory = repo;
             Context = repo;
-            Args = $"ls-tree -z {sha}";
+            Args = $"ls-tree {sha}";
 
             if (!string.IsNullOrEmpty(parentFolder))
                 Args += $" -- \"{parentFolder}\"";

src/ViewModels/ChangeTreeNode.cs

@@ -1,4 +1,3 @@
-using System;
 using System.Collections.Generic;
 
 using CommunityToolkit.Mvvm.ComponentModel;

src/ViewModels/SubmoduleCollection.cs

@@ -1,5 +1,4 @@
-using System;
-using System.Collections.Generic;
+using System.Collections.Generic;
 
 using Avalonia.Collections;
 

src/ViewModels/TagCollection.cs

@@ -1,4 +1,3 @@
-using System;
 using System.Collections.Generic;
 
 using Avalonia.Collections;

src/ViewModels/WorkingCopy.cs

@@ -1652,10 +1652,9 @@ public ContextMenu CreateContextMenuForCommitMessages()
             {
                 for (int i = 0; i < historiesCount; i++)
                 {
-                    var message = _repo.Settings.CommitMessages[i].Trim().ReplaceLineEndings("\n");
-                    var subject = message.Split('\n', 2)[0];
+                    var message = _repo.Settings.CommitMessages[i].Trim().ReplaceLineEndings(" ");
                     var item = new MenuItem();
-                    item.Header = new CommitMessageRecord(subject);
+                    item.Header = new CommitMessageRecord(message);
                     item.Icon = App.CreateMenuIcon("Icons.Histories");
                     item.Click += (_, e) =>
                     {

src/Views/CommitMessageEditor.axaml.cs

@@ -20,15 +20,9 @@ public void AsStandalone(string file)
 
             var content = File.ReadAllText(file).ReplaceLineEndings("\n").Trim();
             var parts = content.Split('\n', 2);
-            if (parts.Length != 2)
-            {
-                Editor.SubjectEditor.Text = content;
-            }
-            else
-            {
-                Editor.SubjectEditor.Text = parts[0];
+            Editor.SubjectEditor.Text = parts[0];
+            if (parts.Length > 1)
                 Editor.DescriptionEditor.Text = parts[1];
-            }
         }
 
         public void AsBuiltin(string msg, Action<string> onSave)
@@ -37,15 +31,9 @@ public void AsBuiltin(string msg, Action<string> onSave)
             _shouldExitApp = false;
 
             var parts = msg.Split('\n', 2);
-            if (parts.Length != 2)
-            {
-                Editor.SubjectEditor.Text = msg;
-            }
-            else
-            {
-                Editor.SubjectEditor.Text = parts[0];
+            Editor.SubjectEditor.Text = parts[0];
+            if (parts.Length > 1)
                 Editor.DescriptionEditor.Text = parts[1];
-            }
         }
 
         protected override void OnClosed(EventArgs e)