revert: getting askpass for every action even when it's not necessary (#1577)

This reverts commit 6822ae3.

Signed-off-by: leo <[email protected]>

Author: love-linger

build/resources/_common/applications/sourcegit.desktop

@@ -1,7 +1,7 @@
 [Desktop Entry]
 Name=SourceGit
 Comment=Open-source & Free Git GUI Client
-Exec=/usr/bin/sourcegit
+Exec=/opt/sourcegit/sourcegit
 Icon=/usr/share/icons/sourcegit.png
 Terminal=false
 Type=Application

build/resources/_common/sourcegit

@@ -21,12 +21,11 @@ mkdir -p %{buildroot}/%{_bindir}
 mkdir -p %{buildroot}/usr/share/applications
 mkdir -p %{buildroot}/usr/share/icons
 cp -f ../../../SourceGit/* %{buildroot}/opt/sourcegit/
-cp -f ../../_common/sourcegit %{buildroot}/%{_bindir}
+ln -rsf %{buildroot}/opt/sourcegit/sourcegit %{buildroot}/%{_bindir}
 cp -r ../../_common/applications %{buildroot}/%{_datadir}
 cp -r ../../_common/icons %{buildroot}/%{_datadir}
 chmod 755 -R %{buildroot}/opt/sourcegit
 chmod 755 %{buildroot}/%{_datadir}/applications/sourcegit.desktop
-chmod 755 %{buildroot}/%{_bindir}/sourcegit
 
 %files
 %dir /opt/sourcegit/

build/resources/appimage/sourcegit

@@ -42,8 +42,7 @@ desktop-file-install resources/_common/applications/sourcegit.desktop --dir Sour
     --set-icon com.sourcegit_scm.SourceGit --set-key=Exec --set-value=AppRun
 mv SourceGit.AppDir/usr/share/applications/{sourcegit,com.sourcegit_scm.SourceGit}.desktop
 cp resources/_common/icons/sourcegit.png SourceGit.AppDir/com.sourcegit_scm.SourceGit.png
-cp -f resources/appimage/sourcegit SourceGit.AppDir/AppRun
-chmod 755 SourceGit.AppDir/AppRun
+ln -rsf SourceGit.AppDir/opt/sourcegit/sourcegit SourceGit.AppDir/AppRun
 ln -rsf SourceGit.AppDir/usr/share/applications/com.sourcegit_scm.SourceGit.desktop SourceGit.AppDir
 cp resources/appimage/sourcegit.appdata.xml SourceGit.AppDir/usr/share/metainfo/com.sourcegit_scm.SourceGit.appdata.xml
 
@@ -54,10 +53,9 @@ mkdir -p resources/deb/usr/bin
 mkdir -p resources/deb/usr/share/applications
 mkdir -p resources/deb/usr/share/icons
 cp -f SourceGit/* resources/deb/opt/sourcegit
-cp -f resources/_common/sourcegit resources/deb/usr/bin/
+ln -rsf resources/deb/opt/sourcegit/sourcegit resources/deb/usr/bin
 cp -r resources/_common/applications resources/deb/usr/share
 cp -r resources/_common/icons resources/deb/usr/share
-chmod 755 resources/deb/usr/bin/sourcegit
 # Calculate installed size in KB
 installed_size=$(du -sk resources/deb | cut -f1)
 # Update the control file

build/resources/rpm/SPECS/build.spec

@@ -172,7 +172,7 @@ private ProcessStartInfo CreateGitStartInfo(bool redirect)
 
             // If an SSH private key was provided, sets the environment.
             if (!start.Environment.ContainsKey("GIT_SSH_COMMAND") && !string.IsNullOrEmpty(SSHKey))
-                start.Environment.Add("GIT_SSH_COMMAND", $"ssh -o AddKeysToAgent=yes -i {SSHKey.Quoted()}");
+                start.Environment.Add("GIT_SSH_COMMAND", $"ssh -i '{SSHKey}'");
 
             // Force using en_US.UTF-8 locale
             if (OperatingSystem.IsLinux())