Skip to content

Commit cc6e486

Browse files
committed
enhance: do NOT modify repository's local configuration if it is equals to default value
1 parent 886b242 commit cc6e486

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

src/ViewModels/RepositoryConfigure.cs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -138,22 +138,22 @@ public void RemoveSelectedIssueTracker()
138138

139139
public void Save()
140140
{
141-
SetIfChanged("user.name", UserName);
142-
SetIfChanged("user.email", UserEmail);
143-
SetIfChanged("commit.gpgsign", GPGCommitSigningEnabled ? "true" : "false");
144-
SetIfChanged("tag.gpgsign", GPGTagSigningEnabled ? "true" : "false");
145-
SetIfChanged("user.signingkey", GPGUserSigningKey);
146-
SetIfChanged("http.proxy", HttpProxy);
141+
SetIfChanged("user.name", UserName, "");
142+
SetIfChanged("user.email", UserEmail, "");
143+
SetIfChanged("commit.gpgsign", GPGCommitSigningEnabled ? "true" : "false", "false");
144+
SetIfChanged("tag.gpgsign", GPGTagSigningEnabled ? "true" : "false", "false");
145+
SetIfChanged("user.signingkey", GPGUserSigningKey, "");
146+
SetIfChanged("http.proxy", HttpProxy, "");
147147
}
148148

149-
private void SetIfChanged(string key, string value)
149+
private void SetIfChanged(string key, string value, string defValue)
150150
{
151151
bool changed = false;
152152
if (_cached.TryGetValue(key, out var old))
153153
{
154154
changed = old != value;
155155
}
156-
else if (!string.IsNullOrEmpty(value))
156+
else if (!string.IsNullOrEmpty(value) && value != defValue)
157157
{
158158
changed = true;
159159
}

0 commit comments

Comments
 (0)