refactor: remove redundant field initialization

Author: NathanBaulch

src/App.Commands.cs

@@ -22,7 +22,7 @@ public Command(Action<object> action)
             public bool CanExecute(object parameter) => _action != null;
             public void Execute(object parameter) => _action?.Invoke(parameter);
 
-            private Action<object> _action = null;
+            private readonly Action<object> _action;
         }
 
         public static bool IsCheckForUpdateCommandVisible

src/App.axaml.cs

@@ -713,10 +713,10 @@ private string FixFontFamilyName(string input)
         [GeneratedRegex(@"^[a-z]+\s+([a-fA-F0-9]{4,40})(\s+.*)?$")]
         private static partial Regex REG_REBASE_TODO();
 
-        private Models.IpcChannel _ipcChannel = null;
-        private ViewModels.Launcher _launcher = null;
-        private ResourceDictionary _activeLocale = null;
-        private ResourceDictionary _themeOverrides = null;
-        private ResourceDictionary _fontsOverrides = null;
+        private Models.IpcChannel _ipcChannel;
+        private ViewModels.Launcher _launcher;
+        private ResourceDictionary _activeLocale;
+        private ResourceDictionary _themeOverrides;
+        private ResourceDictionary _fontsOverrides;
     }
 }

src/Commands/Blame.cs

@@ -92,7 +92,7 @@ private void ParseLine(string line)
         private readonly StringBuilder _content = new StringBuilder();
         private readonly string _dateFormat = Models.DateTimeFormat.Active.DateOnly;
         private string _lastSHA = string.Empty;
-        private bool _needUnifyCommitSHA = false;
+        private bool _needUnifyCommitSHA;
         private int _minSHALen = 64;
     }
 }

src/Commands/Command.cs

@@ -12,7 +12,7 @@ public partial class Command
     {
         public class Result
         {
-            public bool IsSuccess { get; set; } = false;
+            public bool IsSuccess { get; set; }
             public string StdOut { get; set; } = string.Empty;
             public string StdErr { get; set; } = string.Empty;
 

src/Commands/Config.cs

@@ -64,6 +64,6 @@ public async Task<bool> SetAsync(string key, string value, bool allowEmpty = fal
             return await ExecAsync().ConfigureAwait(false);
         }
 
-        private bool _isLocal = false;
+        private readonly bool _isLocal;
     }
 }

src/Commands/Diff.cs

@@ -275,8 +275,8 @@ private void ProcessInlineHighlights()
         private readonly Models.DiffResult _result = new Models.DiffResult();
         private readonly List<Models.TextDiffLine> _deleted = new List<Models.TextDiffLine>();
         private readonly List<Models.TextDiffLine> _added = new List<Models.TextDiffLine>();
-        private Models.TextDiffLine _last = null;
-        private int _oldLine = 0;
-        private int _newLine = 0;
+        private Models.TextDiffLine _last;
+        private int _oldLine;
+        private int _newLine;
     }
 }

src/Commands/QueryCommits.cs

@@ -147,9 +147,9 @@ private async Task MarkFirstMergedAsync()
             }
         }
 
-        private List<Models.Commit> _commits = new List<Models.Commit>();
-        private Models.Commit _current = null;
-        private bool _findFirstMerged = false;
-        private bool _isHeadFounded = false;
+        private readonly List<Models.Commit> _commits = new List<Models.Commit>();
+        private readonly bool _findFirstMerged;
+        private Models.Commit _current;
+        private bool _isHeadFounded;
     }
 }

src/Commands/QueryCommitsForInteractiveRebase.cs

@@ -89,8 +89,8 @@ private void ParseParent(string data)
             _current.Commit.Parents.AddRange(data.Split(separator: ' ', options: StringSplitOptions.RemoveEmptyEntries));
         }
 
-        private List<Models.InteractiveCommit> _commits = [];
-        private Models.InteractiveCommit _current = null;
+        private readonly List<Models.InteractiveCommit> _commits = [];
         private readonly string _boundary;
+        private Models.InteractiveCommit _current;
     }
 }

src/Models/AvatarManager.cs

@@ -30,17 +30,17 @@ public static AvatarManager Instance
             }
         }
 
-        private static AvatarManager _instance = null;
+        private static AvatarManager _instance;
 
         [GeneratedRegex(@"^(?:(\d+)\+)?(.+?)@.+\.github\.com$")]
         private static partial Regex REG_GITHUB_USER_EMAIL();
 
         private readonly Lock _synclock = new();
+        private readonly List<IAvatarHost> _avatars = new List<IAvatarHost>();
+        private readonly Dictionary<string, Bitmap> _resources = new Dictionary<string, Bitmap>();
+        private readonly HashSet<string> _requesting = new HashSet<string>();
+        private readonly HashSet<string> _defaultAvatars = new HashSet<string>();
         private string _storePath;
-        private List<IAvatarHost> _avatars = new List<IAvatarHost>();
-        private Dictionary<string, Bitmap> _resources = new Dictionary<string, Bitmap>();
-        private HashSet<string> _requesting = new HashSet<string>();
-        private HashSet<string> _defaultAvatars = new HashSet<string>();
 
         public void Start()
         {

src/Models/Commit.cs

@@ -42,7 +42,7 @@ public static double OpacityForNotMerged
         public string AuthorTimeShortStr => DateTime.UnixEpoch.AddSeconds(AuthorTime).ToLocalTime().ToString(DateTimeFormat.Active.DateOnly);
         public string CommitterTimeShortStr => DateTime.UnixEpoch.AddSeconds(CommitterTime).ToLocalTime().ToString(DateTimeFormat.Active.DateOnly);
 
-        public bool IsMerged { get; set; } = false;
+        public bool IsMerged { get; set; }
         public bool IsCommitterVisible => !Author.Equals(Committer) || AuthorTime != CommitterTime;
         public bool IsCurrentHead => Decorators.Find(x => x.Type is DecoratorType.CurrentBranchHead or DecoratorType.CurrentCommitHead) != null;