fix: better https regex (#735)

czarkoff · web-flow · commit e3d6ee0f40e6 · 2024-11-24T10:15:17.000+08:00
Fixes #733
diff --git a/src/Models/Remote.cs b/src/Models/Remote.cs
@@ -6,7 +6,7 @@ namespace SourceGit.Models
 {
     public partial class Remote
     {
-        [GeneratedRegex(@"^http[s]?://([\w\-]+@)?[\w\.\-]+(\:[0-9]+)?/[\w\-/~%]+/[\w\-\.%]+(\.git)?$")]
+        [GeneratedRegex(@"^https?://([-a-zA-Z0-9:%._\+~#=]+@)?[-a-zA-Z0-9:%._\+~#=]{1,256}\.[a-zA-Z0-9()]{1,6}(:[0-9]{1,5})?\b(/[-a-zA-Z0-9()@:%_\+.~#?&=]*)*(\.git)?$")]
         private static partial Regex REG_HTTPS();
         [GeneratedRegex(@"^[\w\-]+@[\w\.\-]+(\:[0-9]+)?:[\w\-/~%]+/[\w\-\.%]+(\.git)?$")]
         private static partial Regex REG_SSH1();

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ namespace SourceGit.Models`
`6`	`6`	`{`
`7`	`7`	`public partial class Remote`
`8`	`8`	`{`
`9`		`- [GeneratedRegex(@"^http[s]?://([\w\-]+@)?[\w\.\-]+(\:[0-9]+)?/[\w\-/~%]+/[\w\-\.%]+(\.git)?$")]`
	`9`	`+ [GeneratedRegex(@"^https?://([-a-zA-Z0-9:%._\+~#=]+@)?[-a-zA-Z0-9:%._\+~#=]{1,256}\.[a-zA-Z0-9()]{1,6}(:[0-9]{1,5})?\b(/[-a-zA-Z0-9()@:%_\+.~#?&=])(\.git)?$")]`
`10`	`10`	`private static partial Regex REG_HTTPS();`
`11`	`11`	`[GeneratedRegex(@"^[\w\-]+@[\w\.\-]+(\:[0-9]+)?:[\w\-/~%]+/[\w\-\.%]+(\.git)?$")]`
`12`	`12`	`private static partial Regex REG_SSH1();`