Skip to content

Conversation

gadfly3173
Copy link
Contributor

No description provided.

@love-linger
Copy link
Collaborator

love-linger commented Oct 25, 2024

A small suggestion: should we move localizaton-check.js to build/scripts directory? This folder contains all resources and scripts those only used by Github Action.

The advantage of it is that on Unix-like platforms, .github is not visible by default.

@love-linger love-linger self-assigned this Oct 25, 2024
@love-linger love-linger added the enhancement New feature or request label Oct 25, 2024
@gadfly3173
Copy link
Contributor Author

gadfly3173 commented Oct 25, 2024

Moved. I have no particular preference for the file location. I put it in .github just because this script has little to do with other release scripts used.

@love-linger love-linger merged commit 28773f0 into sourcegit-scm:develop Oct 25, 2024
13 checks passed
@gadfly3173 gadfly3173 deleted the ci/localization branch October 25, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants