refactor: remove goToDefinitionClicks

Author: sqs

src/hoverifier.test.ts

@@ -41,7 +41,6 @@ describe('Hoverifier', () => {
             scheduler.run(({ cold, expectObservable }) => {
                 const hoverifier = createHoverifier({
                     closeButtonClicks: NEVER,
-                    goToDefinitionClicks: NEVER,
                     hoverOverlayElements: of(null),
                     hoverOverlayRerenders: EMPTY,
                     fetchHover: createStubHoverFetcher({ range: hoverRange }, LOADER_DELAY + delayTime),
@@ -103,7 +102,6 @@ describe('Hoverifier', () => {
             scheduler.run(({ cold, expectObservable }) => {
                 const hoverifier = createHoverifier({
                     closeButtonClicks: NEVER,
-                    goToDefinitionClicks: new Observable<MouseEvent>(),
                     hoverOverlayElements: of(null),
                     hoverOverlayRerenders: EMPTY,
                     fetchHover: createStubHoverFetcher(hover, delayTime),
@@ -192,7 +190,6 @@ describe('Hoverifier', () => {
                 scheduler.run(({ cold, expectObservable }) => {
                     const hoverifier = createHoverifier({
                         closeButtonClicks: NEVER,
-                        goToDefinitionClicks: new Observable<MouseEvent>(),
                         hoverOverlayElements: of(null),
                         hoverOverlayRerenders: EMPTY,
                         // Only show on line 24, not line 25 (which is the 2nd click event below).
@@ -265,7 +262,6 @@ describe('Hoverifier', () => {
                 scheduler.run(({ cold, expectObservable }) => {
                     const hoverifier = createHoverifier({
                         closeButtonClicks: NEVER,
-                        goToDefinitionClicks: new Observable<MouseEvent>(),
                         hoverOverlayElements: of(null),
                         hoverOverlayRerenders: EMPTY,
                         // Only show on line 24, not line 25 (which is the 2nd click event below).
@@ -346,7 +342,6 @@ describe('Hoverifier', () => {
             scheduler.run(({ cold, expectObservable }) => {
                 const hoverifier = createHoverifier({
                     closeButtonClicks: new Observable<MouseEvent>(),
-                    goToDefinitionClicks: new Observable<MouseEvent>(),
                     hoverOverlayElements: of(null),
                     hoverOverlayRerenders: EMPTY,
                     fetchHover: createStubHoverFetcher(hover, delayTime),
@@ -418,7 +413,6 @@ describe('Hoverifier', () => {
             scheduler.run(({ cold, expectObservable }) => {
                 const hoverifier = createHoverifier({
                     closeButtonClicks: new Observable<MouseEvent>(),
-                    goToDefinitionClicks: new Observable<MouseEvent>(),
                     hoverOverlayElements: of(null),
                     hoverOverlayRerenders: EMPTY,
                     fetchHover: createStubHoverFetcher(hover),
@@ -480,7 +474,6 @@ describe('Hoverifier', () => {
             scheduler.run(({ cold, expectObservable }) => {
                 const hoverifier = createHoverifier({
                     closeButtonClicks: new Observable<MouseEvent>(),
-                    goToDefinitionClicks: new Observable<MouseEvent>(),
                     hoverOverlayElements: of(null),
                     hoverOverlayRerenders: EMPTY,
                     fetchHover: createStubHoverFetcher(hover),
@@ -563,7 +556,6 @@ describe('Hoverifier', () => {
 
                 const hoverifier = createHoverifier({
                     closeButtonClicks: new Observable<MouseEvent>(),
-                    goToDefinitionClicks: new Observable<MouseEvent>(),
                     hoverOverlayElements: of(null),
                     hoverOverlayRerenders: EMPTY,
                     fetchHover,

src/hoverifier.ts

@@ -67,11 +67,6 @@ export interface HoverifierOptions<C extends object, D, A> {
         relativeElement: HTMLElement
     }>
 
-    /**
-     * Emit on this Observable when the Go-To-Definition button in the HoverOverlay was clicked
-     */
-    goToDefinitionClicks: Subscribable<MouseEvent>
-
     /**
      * Emit on this Observable when the close button in the HoverOverlay was clicked
      */
@@ -316,7 +311,6 @@ export type ContextResolver<C extends object> = (hoveredToken: HoveredToken) =>
  * @template A The type of an action.
  */
 export function createHoverifier<C extends object, D, A>({
-    goToDefinitionClicks,
     closeButtonClicks,
     hoverOverlayRerenders,
     fetchHover,
@@ -736,17 +730,6 @@ export function createHoverifier<C extends object, D, A>({
             })
     )
 
-    // On every click on a go to definition button, reveal loader/error/not found UI
-    subscription.add(
-        goToDefinitionClicks.subscribe(event => {
-            // If we don't have a result yet that would be jumped to by the native <a> tag...
-            if (!container.values.actionsOrError || isErrorLike(container.values.actionsOrError)) {
-                // Prevent default link behaviour (jump will be done programmatically once finished)
-                event.preventDefault()
-            }
-        })
-    )
-
     // When the close button is clicked, unpin, hide and reset the hover
     subscription.add(
         merge(