refactor(hoverifier): improve variable naming

felixfbecker · felixfbecker · commit e6dd2012bdb3 · 2018-07-20T00:45:58.000-07:00
diff --git a/src/hoverifier.ts b/src/hoverifier.ts
@@ -546,13 +546,13 @@ export const createHoverifier = ({
                 // Remember active position in state for blame and range expansion
                 selectedPosition: position,
             })
-            const rows = getCodeElementsInRange({ codeView, position, getCodeElementFromLineNumber })
-            for (const { element } of rows) {
+            const codeElements = getCodeElementsInRange({ codeView, position, getCodeElementFromLineNumber })
+            for (const { element } of codeElements) {
                 convertNode(element)
             }
             // Scroll into view
-            if (rows.length > 0) {
-                scrollIntoCenterIfNeeded(scrollElement, codeView, rows[0].element)
+            if (codeElements.length > 0) {
+                scrollIntoCenterIfNeeded(scrollElement, codeView, codeElements[0].element)
             }
         })
     )

Original file line number	Diff line number	Diff line change
`@@ -546,13 +546,13 @@ export const createHoverifier = ({`
`546`	`546`	`// Remember active position in state for blame and range expansion`
`547`	`547`	`selectedPosition: position,`
`548`	`548`	`})`
`549`		`- const rows = getCodeElementsInRange({ codeView, position, getCodeElementFromLineNumber })`
`550`		`- for (const { element } of rows) {`
	`549`	`+ const codeElements = getCodeElementsInRange({ codeView, position, getCodeElementFromLineNumber })`
	`550`	`+ for (const { element } of codeElements) {`
`551`	`551`	`convertNode(element)`
`552`	`552`	`}`
`553`	`553`	`// Scroll into view`
`554`		`- if (rows.length > 0) {`
`555`		`- scrollIntoCenterIfNeeded(scrollElement, codeView, rows[0].element)`
	`554`	`+ if (codeElements.length > 0) {`
	`555`	`+ scrollIntoCenterIfNeeded(scrollElement, codeView, codeElements[0].element)`
`556`	`556`	`}`
`557`	`557`	`})`
`558`	`558`	`)`