clean up config

Author: sayansisodiya

.env.example

@@ -16,4 +16,4 @@ DEBUG=false
 
 # Amp Configuration
 AMP_API_KEY=
-AMP_SERVER_URL=https://ampcode.com
+# AMP_SERVER_URL=https://ampcode.com  # Optional, defaults to https://ampcode.com

.github/workflows/review.yml

@@ -24,7 +24,7 @@ jobs:
         uses: docker://ghcr.io/sourcegraph/cra-github:latest
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          AMP_SERVER_URL: ${{ vars.AMP_SERVER_URL }}
+          AMP_SERVER_URL: ${{ vars.AMP_SERVER_URL }}  # Optional, defaults to https://ampcode.com
           AMP_API_KEY: ${{ secrets.AMP_API_KEY }}
         with:
           args: node /app/dist/bin/review-action.js

README.md

@@ -32,8 +32,8 @@ The simplest way to add code reviews to any repository:
 
 2. **Configure repository settings**:
    - Go to your repo → Settings → Secrets and variables → Actions
-   - Add **Variable**: `AMP_SERVER_URL` = `https://ampcode.com`
    - Add **Secret**: `AMP_API_KEY` = your Amp API key
+   - (Optional) Add **Variable**: `AMP_SERVER_URL` = `https://ampcode.com` (defaults to https://ampcode.com if not set)
 
 3. **Create a pull request** - reviews will run automatically!
 

config.yml

@@ -23,9 +23,7 @@ server:
 
 amp:
   command: "npx --yes @sourcegraph/amp@latest"
-  server_url: "${AMP_SERVER_URL}"
-  settings:
-    amp.url: "${AMP_SERVER_URL}"
+  server_url: "${AMP_SERVER_URL:-https://ampcode.com}"
 
   prompt_template: |
     Review this code diff as a senior developer. Look for bugs, clear logic errors, and code quality problems.
@@ -46,7 +44,9 @@ amp:
     Diff to review:
     __DIFF_CONTENT__
 
-    Use the tools available in the toolbox (prefixed with tb__) while performing your review. Read any existing PR comments before leaving new comments. 
+    IMPORTANT: Always use the tools available in the toolbox (prefixed with tb__) to leave comments while performing your review.
+
+    Read any existing PR comments before leaving new comments. 
 
     Review the diff content to identify issues. If you find any issues, leave specific inline comments for each issue found.
 

src/config.ts

@@ -30,9 +30,7 @@ const ConfigSchema = z.object({
   amp: z.object({
     command: z.string(),
     server_url: z.string(),
-    settings: z.object({
-      'amp.url': z.string(),
-    }),
+    settings: z.record(z.any()).optional(),
     prompt_template: z.string(),
   }),
 });
@@ -64,10 +62,13 @@ class ConfigLoader {
 
   private processEnvVars(obj: unknown): unknown {
     if (typeof obj === 'string') {
-      return obj.replace(/\$\{([^}]+)\}/g, (_, envVar) => {
+      return obj.replace(/\$\{([^}]+)\}/g, (_, envVarExpr) => {
+        const [envVar, defaultValue] = envVarExpr.split(':-');
         const value = process.env[envVar];
         if (value) {
           return value;
+        } else if (defaultValue !== undefined) {
+          return defaultValue;
         } else {
           console.warn(`Environment variable ${envVar} not found, keeping placeholder`);
           return `\${${envVar}}`;

src/review/reviewer.ts

@@ -20,7 +20,6 @@ export const reviewDiff = async (
     const tempDir = tmpdir();
     const promptFilePath = join(tempDir, `amp-prompt-${uuidv4()}.txt`);
     const resultFilePath = join(tempDir, `amp-result-${uuidv4()}.txt`);
-    const settingsFilePath = join(tempDir, `amp-settings-${uuidv4()}.json`);
 
   try {      
       // Create prompt content
@@ -42,18 +41,11 @@ export const reviewDiff = async (
       const commentsFileName = `comments-${installationId}-${uuidv4()}.jsonl`;
       const commentsFilePath = join(tempDir, commentsFileName);
 
-      // Write settings to file
-      const settings = { 
-        ...ampConfig.settings
-      };
-      
-      writeFileSync(settingsFilePath, JSON.stringify(settings, null, 2), 'utf8');
 
       const threadId = await newThread(tempDir);
       const result = await execute({
         promptFilePath,
         resultFilePath,
-        settingsFilePath,
         folderPath: tempDir,
         debug: true,
         logging: true,