Skip to content

Commit 55546d0

Browse files
committed
remove extra mcp tools; they were causing issues. update docs accordingly
1 parent 70f6d58 commit 55546d0

File tree

13 files changed

+8
-590
lines changed

13 files changed

+8
-590
lines changed

README.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -230,9 +230,6 @@ The app includes a Model Context Protocol (MCP) server that exposes GitHub opera
230230
### Available MCP Tools
231231
- `leave_general_comment` - Leave general comments on pull requests
232232
- `leave_inline_comment` - Leave inline comments on specific lines
233-
- `create_check_run` - Create or update check run status
234-
- `get_pr_info` - Get pull request details and optionally the diff
235-
- `trigger_review` - Start the code review process
236233
- `get_pr_comments` - Get all comments on a pull request
237234

238235
### Usage with AI Agents

config.yml

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ amp:
5757
1. Look at the pull request details to fetch the context before reviewing.
5858
2. Review the diff content to identify issues.
5959
3. Leave specific inline comments or code suggestions for each issue found.
60-
4. Create check run status when the code review is complete.
6160
6261
Always leave actionable, specific comments with suggested fixes.
6362
@@ -129,28 +128,6 @@ amp:
129128
- "Required: message, owner, repo, pr_number, path, line"
130129
- "Optional: commit_sha (will be fetched from PR if not provided)"
131130
- "Example: Comment on line 25 of src/auth.js about missing error handling"
132-
- name: create_check_run
133-
description: Create or update GitHub check run status
134-
instructions:
135-
- "Use to mark review completion with check run status"
136-
- "Required: owner, repo, commit_sha, status ('queued', 'in_progress', 'completed')"
137-
- "Optional: conclusion ('success', 'failure', 'neutral'), title, summary, details_url"
138-
- "Use 'completed' status with 'success' conclusion when review is done"
139-
- "Use 'completed' status with 'failure' conclusion for critical issues"
140-
- name: get_pr_info
141-
description: Get pull request details
142-
instructions:
143-
- "Use to understand context about the pull request before reviewing the diff"
144-
- "Required: owner, repo, pr_number"
145-
- "Optional: include_diff (boolean) to also fetch the diff content"
146-
- "Returns PR info, repository info, and optionally diff content"
147-
- name: trigger_review
148-
description: Start code review process
149-
instructions:
150-
- "Usually called automatically, but available if needed to retrigger code review"
151-
- "Required: owner, repo, pr_number"
152-
- "Optional: commit_sha, force (boolean)"
153-
- "Creates check run and initiates review process"
154131
- name: get_pr_comments
155132
description: Get all comments on a pull request
156133
instructions:

src/mcp/README.md

Lines changed: 5 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -25,39 +25,7 @@ Leave inline comments on specific lines in pull requests.
2525
- `line` (number, required): Line number for the inline comment
2626
- `commit_sha` (string, optional): Commit SHA (will be fetched if not provided)
2727

28-
### 3. `create_check_run`
29-
Create or update check run status.
30-
31-
**Parameters:**
32-
- `owner` (string, required): Repository owner
33-
- `repo` (string, required): Repository name
34-
- `commit_sha` (string, required): Commit SHA to create check run for
35-
- `status` (string, required): Check run status - "queued", "in_progress", or "completed"
36-
- `conclusion` (string, optional): Check run conclusion - "success", "failure", "neutral", "cancelled", "skipped", or "timed_out"
37-
- `title` (string, optional): Check run title
38-
- `summary` (string, optional): Check run summary
39-
- `details_url` (string, optional): Details URL for the check run
40-
41-
### 4. `get_pr_info`
42-
Get pull request details and optionally the diff.
43-
44-
**Parameters:**
45-
- `owner` (string, required): Repository owner
46-
- `repo` (string, required): Repository name
47-
- `pr_number` (number, required): Pull request number
48-
- `include_diff` (boolean, optional): Include diff content (default: false)
49-
50-
### 5. `trigger_review`
51-
Start the code review process.
52-
53-
**Parameters:**
54-
- `owner` (string, required): Repository owner
55-
- `repo` (string, required): Repository name
56-
- `pr_number` (number, required): Pull request number
57-
- `commit_sha` (string, optional): Specific commit SHA to review
58-
- `force` (boolean, optional): Force re-review even if already reviewed (default: false)
59-
60-
### 6. `get_pr_comments`
28+
### 3. `get_pr_comments`
6129
Get all comments on a pull request.
6230

6331
**Parameters:**
@@ -160,10 +128,10 @@ This allows Amp to automatically use the GitHub MCP tools during code reviews.
160128
```
161129
You have access to GitHub tools. To review a pull request:
162130

163-
1. Use get_pr_info to understand the context
131+
1. Use get_pr_comments to see existing feedback
164132
2. Review the code changes
165133
3. Use leave_inline_comment to add specific feedback
166-
4. Use create_check_run to mark the review complete
134+
4. Use leave_general_comment for overall observations
167135

168136
Owner: octocat
169137
Repo: Hello-World
@@ -174,23 +142,17 @@ PR Number: 123
174142
175143
The tools are designed to work together in a typical code review workflow:
176144
177-
1. **Get Context**: `get_pr_info` to fetch PR details and optionally the diff
178-
2. **Check Existing Feedback**: `get_pr_comments` to see what's already been discussed
179-
3. **Leave Feedback**:
145+
1. **Check Existing Feedback**: `get_pr_comments` to see what's already been discussed
146+
2. **Leave Feedback**:
180147
- `leave_inline_comment` for specific line-level issues
181148
- `leave_general_comment` for overall observations
182-
4. **Update Status**: `create_check_run` to mark the review as complete
183-
5. **Re-trigger if Needed**: `trigger_review` to restart the process
184149

185150
## Development
186151

187152
The tools are organized in the `/src/mcp/tools/` directory:
188153
- `leave_comment.ts` - General comment functionality
189154
- `leave_inline_comment.ts` - Inline comment functionality
190-
- `create_check_run.ts` - Check run status updates
191-
- `get_pr_info.ts` - PR information retrieval
192155
- `get_pr_comments.ts` - PR comments retrieval
193-
- `trigger_review.ts` - Review triggering
194156

195157
The server implementations are:
196158
- `server.ts` - Standalone stdio MCP server

src/mcp/http-server.ts

Lines changed: 0 additions & 128 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,10 @@ import { cors } from "hono/cors";
33
import { getConfig, Config } from "../config.js";
44
import { leaveGeneralComment } from "./tools/leave_comment.js";
55
import { leaveInlineComment } from "./tools/leave_inline_comment.js";
6-
import { createCheckRun } from "./tools/create_check_run.js";
7-
import { getPRInfo } from "./tools/get_pr_info.js";
8-
import { triggerReview } from "./tools/trigger_review.js";
96
import { getPRComments } from "./tools/get_pr_comments.js";
107
import {
118
validateLeaveGeneralCommentArgs,
129
validateLeaveInlineCommentArgs,
13-
validateCreateCheckRunArgs,
14-
validateGetPRInfoArgs,
15-
validateTriggerReviewArgs,
1610
validateGetPRCommentsArgs,
1711
} from "./validation.js";
1812

@@ -263,108 +257,6 @@ function handleToolsList(c: Context, body: unknown) {
263257
required: ["message", "owner", "repo", "pr_number", "path", "line"],
264258
},
265259
},
266-
{
267-
name: "create_check_run",
268-
description: "Create or update check run status",
269-
inputSchema: {
270-
type: "object",
271-
properties: {
272-
owner: {
273-
type: "string",
274-
description: "Repository owner",
275-
},
276-
repo: {
277-
type: "string",
278-
description: "Repository name",
279-
},
280-
commit_sha: {
281-
type: "string",
282-
description: "Commit SHA to create check run for",
283-
},
284-
status: {
285-
type: "string",
286-
enum: ["queued", "in_progress", "completed"],
287-
description: "Check run status",
288-
},
289-
conclusion: {
290-
type: "string",
291-
enum: ["success", "failure", "neutral", "cancelled", "skipped", "timed_out"],
292-
description: "Check run conclusion (optional)",
293-
},
294-
title: {
295-
type: "string",
296-
description: "Check run title (optional)",
297-
},
298-
summary: {
299-
type: "string",
300-
description: "Check run summary (optional)",
301-
},
302-
details_url: {
303-
type: "string",
304-
description: "Details URL for the check run (optional)",
305-
},
306-
},
307-
required: ["owner", "repo", "commit_sha", "status"],
308-
},
309-
},
310-
{
311-
name: "get_pr_info",
312-
description: "Get pull request details",
313-
inputSchema: {
314-
type: "object",
315-
properties: {
316-
owner: {
317-
type: "string",
318-
description: "Repository owner",
319-
},
320-
repo: {
321-
type: "string",
322-
description: "Repository name",
323-
},
324-
pr_number: {
325-
type: "number",
326-
description: "Pull request number",
327-
},
328-
include_diff: {
329-
type: "boolean",
330-
description: "Include diff content (optional, default: false)",
331-
default: false,
332-
},
333-
},
334-
required: ["owner", "repo", "pr_number"],
335-
},
336-
},
337-
{
338-
name: "trigger_review",
339-
description: "Start code review process",
340-
inputSchema: {
341-
type: "object",
342-
properties: {
343-
owner: {
344-
type: "string",
345-
description: "Repository owner",
346-
},
347-
repo: {
348-
type: "string",
349-
description: "Repository name",
350-
},
351-
pr_number: {
352-
type: "number",
353-
description: "Pull request number",
354-
},
355-
commit_sha: {
356-
type: "string",
357-
description: "Specific commit SHA to review (optional)",
358-
},
359-
force: {
360-
type: "boolean",
361-
description: "Force re-review even if already reviewed (optional)",
362-
default: false,
363-
},
364-
},
365-
required: ["owner", "repo", "pr_number"],
366-
},
367-
},
368260
{
369261
name: "get_pr_comments",
370262
description: "Get all comments on a pull request",
@@ -446,26 +338,6 @@ async function handleToolsCall(c: Context, body: unknown, config: Config) {
446338
}
447339
break;
448340

449-
case "create_check_run":
450-
result = await createCheckRun(
451-
validateCreateCheckRunArgs(args),
452-
config
453-
);
454-
break;
455-
456-
case "get_pr_info":
457-
result = await getPRInfo(
458-
validateGetPRInfoArgs(args),
459-
config
460-
);
461-
break;
462-
463-
case "trigger_review":
464-
result = await triggerReview(
465-
validateTriggerReviewArgs(args),
466-
config
467-
);
468-
break;
469341

470342
case "get_pr_comments":
471343
result = await getPRComments(

0 commit comments

Comments
 (0)