unify GitHubClient creation

Author: sayansisodiya

README.md

@@ -46,6 +46,12 @@ podman push ghcr.io/your-username/cra-github:latest
 
 Update the workflow file to use your image: `docker://ghcr.io/your-username/cra-github:latest`
 
+Example for the current `review.yml`:
+
+```bash
+podman build -t ghcr.io/sayansisodiya/cra-github:latest . && podman push ghcr.io/sayansisodiya/cra-github:latest
+```
+
 ### Local Development
 
 1. **Clone and Install**

src/github/client.ts

@@ -28,25 +28,26 @@ export class GitHubClient {
     this.baseUrl = (githubConfig.base_url ?? 'https://api.github.com').replace(/\/$/, '');
   }
 
-  static forInstallation(config: Config, installationId: number): GitHubClient {
-    return new GitHubClient(config, installationId);
-  }
-
-  static fromEnv(config: Config): GitHubClient {
+  static create(config: Config, options?: { installationId?: number; token?: string }): GitHubClient {
+    if (options?.token) {
+      const configWithToken = {
+        ...config,
+        github: {
+          ...config.github,
+          token: options.token
+        }
+      };
+      return new GitHubClient(configWithToken);
+    }
+    
+    if (options?.installationId) {
+      return new GitHubClient(config, options.installationId);
+    }
+    
+    // Auto-detect from environment (GITHUB_INSTALLATION_ID)
     return new GitHubClient(config);
   }
 
-  static forToken(config: Config, token: string): GitHubClient {
-    const configWithToken = {
-      ...config,
-      github: {
-        ...config.github,
-        token
-      }
-    };
-    return new GitHubClient(configWithToken);
-  }
-
   private async getAuthHeaders(): Promise<Record<string, string>> {
     const headers = {
       'Accept': 'application/vnd.github.v3+json',

src/github/process-review.ts

@@ -12,9 +12,11 @@ export async function processReview(
 
   // Use GITHUB_TOKEN from Actions environment if available, otherwise use GitHub App
   const githubToken = process.env.GITHUB_TOKEN;
-  const githubClient = githubToken 
-    ? GitHubClient.forToken(config, githubToken)
-    : GitHubClient.forInstallation(config, installationId);
+  const githubClient = GitHubClient.create(config, 
+    githubToken 
+      ? { token: githubToken }
+      : { installationId }
+  );
 
   try {
     // Extract PR information

src/routes/github.ts

@@ -140,7 +140,7 @@ async function handleCheckRunActionEvent(payload: any) {
     // We need to fetch the full PR data since we don't have it in the check run payload
     const config = getConfig();
     const { GitHubClient } = await import('../github/client.js');
-    const githubClient = GitHubClient.forInstallation(config, installationId);
+    const githubClient = GitHubClient.create(config, { installationId });
 
     console.log(`Fetching PR ${prNumber} details for re-review job ${jobId}`);
     const prData = await githubClient.getPRInfo(repository.owner.login, repository.name, prNumber);

toolbox/get-pr-comments.js

@@ -38,7 +38,7 @@ if (action === 'execute') {
       const { getConfig } = await distImport('config.js');
 
       const config = getConfig();
-      const gh = GitHubClient.fromEnv(config);
+      const gh = GitHubClient.create(config);
 
       const comments = await gh.getPRComments(owner, repo, prNumber);