refactor to use zod schemas and reduce any usage

Author: sayansisodiya

package-lock.json

@@ -31,7 +31,8 @@
     "js-yaml": "^4.1.0",
     "jsonwebtoken": "^9.0.2",
     "node-fetch": "^3.3.2",
-    "uuid": "^10.0.0"
+    "uuid": "^10.0.0",
+    "zod": "^3.25.76"
   },
   "devDependencies": {
     "@types/js-yaml": "^4.0.9",

package.json

@@ -1,69 +1,67 @@
 import { readFileSync } from 'fs';
 import * as yaml from 'js-yaml';
 import { config } from 'dotenv';
+import { z } from 'zod';
 
 // Load environment variables
 config();
 
-interface MCPServer {
-  command: string;
-  args?: string[];
-  env?: Record<string, string>;
-}
-
-interface AmpSettings {
-  'amp.url': string;
-  'amp.mcpServers': {
-    [key: string]: MCPServer;
-  };
-}
+// Single source of truth: Zod schema for config validation
+const ConfigSchema = z.object({
+  github: z.object({
+    base_url: z.string(),
+    token: z.string().optional(),
+    check_name: z.string(),
+    development_mode: z.boolean(),
+    bot_username: z.string(),
+    webhook_secret: z.string().optional(),
+  }),
+  queue: z.object({
+    max_workers: z.coerce.number(),
+    max_queue_size: z.coerce.number(),
+    retry_after_seconds: z.coerce.number(),
+  }),
+  diff_splitting: z.object({
+    max_chunk_size: z.coerce.number(),
+    max_concurrent: z.coerce.number(),
+  }),
+  server: z.object({
+    port: z.string(),
+    debug: z.string(),
+  }),
+  amp: z.object({
+    timeout: z.string(),
+    command: z.string(),
+    server_url: z.string(),
+    settings: z.object({
+      'amp.url': z.string(),
+      'amp.mcpServers': z.record(z.object({
+        command: z.string(),
+        args: z.array(z.string()).optional(),
+        env: z.record(z.string()).optional(),
+      })),
+    }),
+    prompt_template: z.string(),
+    tools: z.array(z.object({
+      name: z.string(),
+      description: z.string(),
+      instructions: z.array(z.string()),
+    })),
+  }),
+});
 
-interface Tool {
-  name: string;
-  description: string;
-  instructions: string[];
-}
-
-export interface Config {
-  github: {
-    base_url: string;
-    token: string;
-    check_name: string;
-    development_mode: boolean;
-    bot_username: string;
-    webhook_secret?: string;
-  };
-  queue: {
-    max_workers: number;
-    max_queue_size: number;
-    retry_after_seconds: number;
-  };
-  diff_splitting: {
-    max_chunk_size: number;
-    max_concurrent: number;
-  };
-  server: {
-    port: string;
-    debug: string;
-  };
-  amp: {
-    timeout: string;
-    command: string;
-    server_url: string;
-    settings: AmpSettings;
-    prompt_template: string;
-    tools: Tool[];
-  };
-}
+// Export the inferred type as the single source of truth
+export type Config = z.infer<typeof ConfigSchema>;
 
 class ConfigLoader {
   private static instance: ConfigLoader;
   private config: Config;
 
-  private constructor() {    
+  private constructor() {
     const configFile = readFileSync('config.yml', 'utf8');
-    const rawConfig = yaml.load(configFile) as any;
-    this.config = this.processEnvVars(rawConfig);
+    const rawConfig = yaml.load(configFile);
+    const processedConfig = this.processEnvVars(rawConfig);
+    this.config = ConfigSchema.parse(processedConfig);
   }
 
   static getInstance(): ConfigLoader {
@@ -77,7 +75,7 @@ class ConfigLoader {
     return this.config;
   }
 
-  private processEnvVars(obj: any): any {
+  private processEnvVars(obj: unknown): unknown {
     if (typeof obj === 'string') {
       return obj.replace(/\$\{([^}]+)\}/g, (_, envVar) => {
         const value = process.env[envVar];
@@ -93,7 +91,7 @@ class ConfigLoader {
       return obj.map(item => this.processEnvVars(item));
     }
     if (obj && typeof obj === 'object') {
-      const result: any = {};
+      const result: Record<string, unknown> = {};
       for (const [key, value] of Object.entries(obj)) {
         result[key] = this.processEnvVars(value);
       }

src/config.ts

@@ -1,4 +1,4 @@
-import { Hono } from "hono";
+import { Hono, Context, Next } from "hono";
 import { cors } from "hono/cors";
 // Remove unused imports
 import { getConfig, Config } from "../config.js";
@@ -33,7 +33,7 @@ export function createMCPRoutes(): Hono {
   );
 
   // Middleware to validate Authorization header
-  const authMiddleware = async (c: any, next: any) => {
+  const authMiddleware = async (c: Context, next: Next) => {
     const authHeader = c.req.header("Authorization");
     const expectedToken = process.env.MCP_AUTH_TOKEN;
 
@@ -83,18 +83,20 @@ export function createMCPRoutes(): Hono {
       const body = await c.req.json();
       console.log("🔍 Received MCP request:", JSON.stringify(body, null, 2));
 
+      const bodyObj = body as Record<string, unknown>;
+      
       // Handle JSON-RPC request
-      if (body.jsonrpc !== "2.0") {
-        console.log("❌ Invalid JSON-RPC version:", body.jsonrpc);
+      if (bodyObj.jsonrpc !== "2.0") {
+        console.log("❌ Invalid JSON-RPC version:", bodyObj.jsonrpc);
         return c.json({ 
           jsonrpc: "2.0", 
           error: { code: -32600, message: "Invalid Request" }, 
-          id: body.id || null 
+          id: bodyObj.id || null 
         }, 400);
       }
 
-      console.log("📋 Method:", body.method, "ID:", body.id);
-      switch (body.method) {
+      console.log("📋 Method:", bodyObj.method, "ID:", bodyObj.id);
+      switch (bodyObj.method) {
         case "initialize":
           console.log("🔧 Handling initialize");
           return handleInitialize(c, body);
@@ -112,7 +114,7 @@ export function createMCPRoutes(): Hono {
           return c.json({
             jsonrpc: "2.0",
             error: { code: -32601, message: "Method not found" },
-            id: body.id || null
+            id: bodyObj.id || null
           }, 400);
       }
     } catch (error) {
@@ -153,9 +155,10 @@ export function createMCPRoutes(): Hono {
   return app;
 }
 
-function handleInitialize(c: any, body: any) {
+function handleInitialize(c: Context, body: unknown) {
   try {
-    console.log("🚀 Initializing MCP server with params:", body.params);
+    const bodyObj = body as Record<string, unknown>;
+    console.log("🚀 Initializing MCP server with params:", bodyObj.params);
 
     return c.json({
       jsonrpc: "2.0",
@@ -169,19 +172,19 @@ function handleInitialize(c: any, body: any) {
           version: "2.0.0"
         }
       },
-      id: body.id
+      id: bodyObj.id
     });
   } catch (error) {
     console.error("Error during initialization:", error);
     return c.json({
       jsonrpc: "2.0",
       error: { code: -32603, message: "Internal error" },
-      id: body.id || null
+      id: (body as Record<string, unknown>).id || null
     }, 500);
   }
 }
 
-function handleInitializedNotification(c: any, body: any) {
+function handleInitializedNotification(c: Context, body: unknown) {
   try {
     console.log("📢 Received initialized notification");
     // Notifications don't require a response, but we return 202 Accepted
@@ -191,14 +194,14 @@ function handleInitializedNotification(c: any, body: any) {
     return c.json({
       jsonrpc: "2.0",
       error: { code: -32603, message: "Internal error" },
-      id: body.id || null
+      id: (body as Record<string, unknown>).id || null
     }, 500);
   }
 }
 
-function handleToolsList(c: any, body: any) {
+function handleToolsList(c: Context, body: unknown) {
   try {
-    console.log("📋 Listing tools for request ID:", body.id);
+    console.log("📋 Listing tools for request ID:", (body as Record<string, unknown>).id);
     const tools = [
         {
           name: "leave_general_comment",
@@ -394,29 +397,30 @@ function handleToolsList(c: any, body: any) {
       return c.json({ 
         jsonrpc: "2.0", 
         result: { tools }, 
-        id: body.id 
+        id: (body as Record<string, unknown>).id 
       });
     } catch (error) {
       console.error("Error listing tools:", error);
       return c.json({
         jsonrpc: "2.0",
         error: { code: -32603, message: "Internal error" },
-        id: body.id || null
+        id: (body as Record<string, unknown>).id || null
       }, 500);
     }
 }
 
-async function handleToolsCall(c: any, body: any, config: Config, githubClient: GitHubClient) {
+async function handleToolsCall(c: Context, body: unknown, config: Config, githubClient: GitHubClient) {
+  const bodyObj = body as Record<string, unknown>;
   try {
-    console.log("🔧 Tool call params:", JSON.stringify(body.params, null, 2));
-    const { name, arguments: args } = body.params || {};
+    console.log("🔧 Tool call params:", JSON.stringify(bodyObj.params, null, 2));
+    const { name, arguments: args } = (bodyObj.params as Record<string, unknown>) || {};
 
     if (!name) {
       console.log("❌ Missing tool name in params");
       return c.json({
         jsonrpc: "2.0",
         error: { code: -32602, message: "Invalid params: missing tool name" },
-        id: body.id || null
+        id: bodyObj.id || null
       }, 400);
     }
 
@@ -484,15 +488,15 @@ async function handleToolsCall(c: any, body: any, config: Config, githubClient:
         return c.json({
           jsonrpc: "2.0",
           error: { code: -32601, message: `Unknown tool: ${name}` },
-          id: body.id || null
+          id: bodyObj.id || null
         }, 400);
     }
 
     console.log("✅ Tool call successful, result:", JSON.stringify(result, null, 2));
     return c.json({
       jsonrpc: "2.0",
       result,
-      id: body.id
+      id: bodyObj.id
     });
   } catch (error) {
     console.error("Error calling tool:", error);
@@ -502,7 +506,7 @@ async function handleToolsCall(c: any, body: any, config: Config, githubClient:
         code: -32603, 
         message: error instanceof Error ? error.message : "Unknown error" 
       },
-      id: body.id || null
+      id: bodyObj.id || null
     }, 500);
   }
 }

src/mcp/http-server.ts

@@ -13,7 +13,7 @@ export async function getPRComments(
   githubClient: GitHubClient
 ): Promise<{ 
   success: boolean; 
-  comments?: any[]; 
+  comments?: unknown[]; 
   total_comments?: number;
   error?: string 
 }> {

src/mcp/tools/get_pr_comments.ts

@@ -14,9 +14,9 @@ export async function getPRInfo(
   githubClient: GitHubClient
 ): Promise<{ 
   success: boolean; 
-  pr_info?: any; 
+  pr_info?: unknown; 
   diff?: string;
-  repository_info?: any;
+  repository_info?: unknown;
   error?: string 
 }> {
   try {