Skip to content

Commit d8e7176

Browse files
committed
clean up schemas
1 parent fe264f5 commit d8e7176

File tree

4 files changed

+4
-8
lines changed

4 files changed

+4
-8
lines changed

src/github/process-review.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,8 @@ export async function processReview(
8181
const inlineComments = comments.filter(c => c.type === 'inline');
8282
const generalComments = comments.filter(c => c.type === 'general');
8383

84+
// TODO(sayans): GitHub API allows <= 30 comments per review, so we need to add splitting logic if there are > 30 comments
85+
8486
console.log(`📝 Collected ${inlineComments.length} inline comments and ${generalComments.length} general comments`);
8587

8688
// Create review summary from general comments

src/mcp/tools/leave_comment.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@ import { getCollector } from '../comment-collector.js';
22

33
export interface LeaveGeneralCommentArgs {
44
message: string;
5-
owner: string;
6-
repo: string;
7-
pr_number: number;
85
}
96

107
export async function leaveGeneralComment(

src/mcp/tools/leave_inline_comment.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@ import { getCollector } from '../comment-collector.js';
22

33
export interface LeaveInlineCommentArgs {
44
message: string;
5-
owner: string;
6-
repo: string;
7-
pr_number: number;
85
path: string;
96
line: number;
107
commit_sha?: string;

src/mcp/validation.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@ const ownerRepoPr = z.object({
1111
});
1212

1313
// Schema definitions
14-
const LeaveGeneralCommentArgsSchema = ownerRepoPr.extend({
14+
const LeaveGeneralCommentArgsSchema = z.object({
1515
message: z.string(),
1616
});
1717

18-
const LeaveInlineCommentArgsSchema = ownerRepoPr.extend({
18+
const LeaveInlineCommentArgsSchema = z.object({
1919
message: z.string(),
2020
path: z.string(),
2121
line: z.number(),

0 commit comments

Comments
 (0)