Skip to content

Commit 74c9bff

Browse files
authored
Fix Jaeger ports for HTTP tracing (#1128)
Updating Docker repo to match the fix in the Helm repo from a few months ago, so that otel-collector is sending trace data to Jaeger on the same port that Jaeger is listening on. ### Checklist <!-- Kubernetes and Docker Compose MUST be kept in sync. You should not merge a change here without a corresponding change in the other repository, unless it truly is specific to this repository. If uneeded, add link or explanation of why it is not needed here. --> * [ ] Sister [deploy-sourcegraph](https://github.com/sourcegraph/deploy-sourcegraph) change: * [ ] Sister [customer-replica](https://github.com/sourcegraph/deploy-sourcegraph-docker-customer-replica-1) change (if necessary, for any changes affecting pure-docker or configuration): * [ ] All images have a valid tag and SHA256 sum ### Test plan Tested manually `docker-compose -f docker-compose.yaml -f jaeger/docker-compose.yaml -f override.yaml up -d --remove-orphans`
1 parent c7101bd commit 74c9bff

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

docker-compose/jaeger/docker-compose.yaml

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,27 +18,29 @@ services:
1818
- '0.0.0.0:16686:16686'
1919
# Collector port
2020
- '0.0.0.0:14250:14250'
21-
- '0.0.0.0:4320:4320' # gRPC port
22-
- '0.0.0.0:4321:4321' # HTTP port
21+
- '0.0.0.0:4320:4320' # gRPC
22+
- '0.0.0.0:4321:4321' # HTTP
2323
# Agent ports
2424
- '0.0.0.0:5778:5778'
2525
- '0.0.0.0:6831:6831'
2626
- '0.0.0.0:6832:6832'
2727
networks:
2828
- sourcegraph
2929
restart: always
30-
command: ['--memory.max-traces=20000', "--sampling.strategies-file=/etc/jaeger/sampling_strategies.json", "--collector.otlp.enabled" ]
31-
environment:
32-
- 'SAMPLING_STRATEGIES_FILE=/etc/jaeger/sampling_strategies.json'
33-
- 'COLLECTOR_OTLP_ENABLED=true'
34-
- 'JAEGER_OTLP_GRPC_PORT=4320'
35-
- 'JAEGER_OTLP_HTTP_PORT=4321'
30+
command: [
31+
'--memory.max-traces=20000',
32+
"--sampling.strategies-file=/etc/jaeger/sampling_strategies.json",
33+
"--collector.otlp.enabled",
34+
"--collector.otlp.grpc.host-port=:4320",
35+
"--collector.otlp.http.host-port=:4321"
36+
]
3637

3738
# Configure collector to send traces to Jaeger
3839
otel-collector:
3940
environment:
4041
- JAEGER_HOST=jaeger
4142
- JAEGER_OTLP_GRPC_PORT=4320
43+
- JAEGER_OTLP_HTTP_PORT=4321
4244
command: ['--config', '/etc/otel-collector/configs/jaeger.yaml']
4345

4446
# Let frontend proxy to Jaeger interface

0 commit comments

Comments
 (0)