sourcegraph: make searcher and symbols headless (#250)

* make searcher and symbols headless

* update changelog

* update changelog and fix syntax for headless services

* update changelog pr

* remove commented line

Author: Sam Johns

charts/sourcegraph/CHANGELOG.md

@@ -7,13 +7,17 @@ Use `**BREAKING**:` to denote a breaking change
 <!-- START CHANGELOG -->
 
 ## Unreleased
-* The default `hostPort`s for OpenTelemetry agent pods deployed by the DaemonSet can now be overridden by setting `openTelemetry.agent.hostPorts` for one or more of `otlpGrpc`, `otlpHttp`, and `zpages`. This allows multiple instances of Sourcegraph to be deployed on a single cluster [#245](https://github.com/sourcegraph/deploy-sourcegraph-helm/pull/245).
-* Update default `searcher` replicas from 2 --> 1
+
 
 ## 4.5.0
 
 - Sourcegraph 4.5.0 is now available
 
+
+- The default `hostPort`s for OpenTelemetry agent pods deployed by the DaemonSet can now be overridden by setting `openTelemetry.agent.hostPorts` for one or more of `otlpGrpc`, `otlpHttp`, and `zpages`. This allows multiple instances of Sourcegraph to be deployed on a single cluster [#245](https://github.com/sourcegraph/deploy-sourcegraph-helm/pull/245).
+- Update default `searcher` replicas from 2 --> 1
+- Update `searcher` and `symbols` services to be headless.
+  - Before upgrading, delete your `searcher` and `symbols` services (ex: `kubectl delete svc/searcher svc/symbols`) [#250](https://github.com/sourcegraph/deploy-sourcegraph-helm/pull/250)
 - Deploy Sourcegraph Executors now deployable via helm [#236](https://github.com/sourcegraph/deploy-sourcegraph-helm/pull/236).
 - Searcher and Symbols now use StatefulSets and PVCs to avoid large `ephermeralStorage` requests [#242](https://github.com/sourcegraph/deploy-sourcegraph-helm/pull/242)
 

charts/sourcegraph/templates/searcher/searcher.Service.yaml

@@ -16,6 +16,7 @@ metadata:
     {{- end }}
   name: searcher
 spec:
+  clusterIP: None
   ports:
   - name: http
     port: 3181
@@ -26,4 +27,3 @@ spec:
   selector:
     {{- include "sourcegraph.selectorLabels" . | nindent 4 }}
     app: searcher
-  type: {{ .Values.searcher.serviceType | default "ClusterIP" }}

charts/sourcegraph/templates/symbols/symbols.Service.yaml

@@ -16,6 +16,7 @@ metadata:
     {{- end }}
   name: symbols
 spec:
+  clusterIP: None
   ports:
   - name: http
     port: 3184
@@ -26,4 +27,3 @@ spec:
   selector:
     {{- include "sourcegraph.selectorLabels" . | nindent 4 }}
     app: symbols
-  type: {{ .Values.symbols.serviceType | default "ClusterIP" }}