Skip to content

Commit 3121258

Browse files
authored
Create config for sgTestConnection enabled (#706)
Allow self-hosted customers to disable the sg-test-connection pod, similar to how the Cloud instances do (sourcegraph/cloud#8) ### Checklist - [x] Follow the [manual testing process](https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/TEST.md) - [ ] Update [changelog](https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/charts/sourcegraph/CHANGELOG.md) - [ ] Update [Kubernetes update doc](https://docs.sourcegraph.com/admin/updates/kubernetes) ### Test plan Ran `helm template`, `helm lint`, and `helm unittest`, all passed <!-- As part of SOC2/GN-104 and SOC2/GN-105 requirements, all pull requests are REQUIRED to provide a "test plan". A test plan is a loose explanation of what you have done or implemented to test this, as outlined in our Testing principles and guidelines: https://docs.sourcegraph.com/dev/background-information/testing_principles Write your test plan here after the "Test plan" header. -->
1 parent 2e145ab commit 3121258

File tree

3 files changed

+8
-1
lines changed

3 files changed

+8
-1
lines changed

charts/sourcegraph/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -300,6 +300,7 @@ In addition to the documented values, all services also support the following va
300300
| searcher.serviceAccount.create | bool | `false` | Enable creation of ServiceAccount for `searcher` |
301301
| searcher.serviceAccount.name | string | `""` | Name of the ServiceAccount to be created or an existing ServiceAccount |
302302
| searcher.storageSize | string | `"26Gi"` | Size of the PVC for searcher pods to store cache data |
303+
| sgTestConnection | object | `{"enabled":true}` | Enable the busybox connection test after deployment |
303304
| sourcegraph.affinity | object | `{}` | Global Affinity, learn more from the [Kubernetes documentation](https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#affinity-and-anti-affinity) |
304305
| sourcegraph.image.defaultTag | string | `"{{ .Chart.AppVersion }}"` | Global docker image tag |
305306
| sourcegraph.image.pullPolicy | string | `"IfNotPresent"` | Global docker image pull policy |

charts/sourcegraph/templates/tests/test-connection.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
{{- if .Values.sgTestConnection.enabled }}
12
apiVersion: v1
23
kind: Pod
34
metadata:
@@ -12,4 +13,5 @@ spec:
1213
image: busybox
1314
command: ['wget']
1415
args: ['sourcegraph-frontend:30080/']
15-
restartPolicy: Never
16+
restartPolicy: Never
17+
{{- end }}

charts/sourcegraph/values.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1266,3 +1266,7 @@ extraResources: []
12661266
# preemptionPolicy: Never
12671267
# description: "gitserver priority class"
12681268
priorityClasses: []
1269+
1270+
# -- Enable the busybox connection test after deployment
1271+
sgTestConnection:
1272+
enabled: true

0 commit comments

Comments
 (0)