Skip to content

Commit 670b4b7

Browse files
authored
Fix port naming in codeintel-db service spec (#275)
* Fix port naming in codeintel-db service spec Ultimately this change is minor, but may prevent confusion. The port name and targetPort name are not actually used for anything besides human readability to my knowledge and there are no known issues with the current manifest. This does bring things in line with the convention in use in codeinsights-db service file though, and will eliminate possible confusion by readers [Codeinsights manifest](https://sourcegraph.com/github.com/sourcegraph/deploy-sourcegraph-helm@release/5.0/-/blob/charts/sourcegraph/templates/codeinsights-db/codeinsights-db.Service.yaml?L23:5) * make all the port names postgres * changelog
1 parent 7a93ab1 commit 670b4b7

File tree

7 files changed

+10
-9
lines changed

7 files changed

+10
-9
lines changed

charts/sourcegraph/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ Use `**BREAKING**:` to denote a breaking change
88

99
## Unreleased
1010

11+
- Port names for all the DBs are renamed to `postgres` to create consistency across the deployments [#275](https://github.com/sourcegraph/deploy-sourcegraph-helm/pull/275)
1112

1213
## 5.0.0
1314

charts/sourcegraph/templates/codeinsights-db/codeinsights-db.Service.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ metadata:
1818
name: codeinsights-db
1919
spec:
2020
ports:
21-
- name: codeinsights-db
21+
- name: postgres
2222
port: 5432
23-
targetPort: codeinsights-db
23+
targetPort: postgres
2424
selector:
2525
{{- include "sourcegraph.selectorLabels" . | nindent 4 }}
2626
app: codeinsights-db

charts/sourcegraph/templates/codeinsights-db/codeinsights-db.StatefulSet.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ spec:
8080
terminationMessagePolicy: FallbackToLogsOnError
8181
ports:
8282
- containerPort: 5432
83-
name: codeinsights-db
83+
name: postgres
8484
{{- if not .Values.sourcegraph.localDevMode }}
8585
resources:
8686
{{- toYaml .Values.codeInsightsDB.resources | nindent 10 }}

charts/sourcegraph/templates/codeintel-db/codeintel-db.Service.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ metadata:
1818
name: codeintel-db
1919
spec:
2020
ports:
21-
- name: pgsql
21+
- name: postgres
2222
port: 5432
23-
targetPort: pgsql
23+
targetPort: postgres
2424
selector:
2525
{{- include "sourcegraph.selectorLabels" . | nindent 4 }}
2626
app: codeintel-db

charts/sourcegraph/templates/codeintel-db/codeintel-db.StatefulSet.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ spec:
9191
periodSeconds: 10
9292
ports:
9393
- containerPort: 5432
94-
name: pgsql
94+
name: postgres
9595
{{- if not .Values.sourcegraph.localDevMode }}
9696
resources:
9797
{{- toYaml .Values.codeIntelDB.resources | nindent 10 }}

charts/sourcegraph/templates/pgsql/pgsql.Service.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ metadata:
1818
name: pgsql
1919
spec:
2020
ports:
21-
- name: pgsql
21+
- name: postgres
2222
port: 5432
23-
targetPort: pgsql
23+
targetPort: postgres
2424
selector:
2525
{{- include "sourcegraph.selectorLabels" . | nindent 4 }}
2626
app: pgsql

charts/sourcegraph/templates/pgsql/pgsql.StatefulSet.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ spec:
9191
{{- end }}
9292
ports:
9393
- containerPort: 5432
94-
name: pgsql
94+
name: postgres
9595
{{- if not .Values.sourcegraph.localDevMode }}
9696
resources:
9797
{{- toYaml .Values.pgsql.resources | nindent 10 }}

0 commit comments

Comments
 (0)