Skip to content

Commit 6e75f27

Browse files
committed
Fix promoteToPublic.finalize github:pr step
The final github:pr step in the promoteToPublic.finalize workflow was incorrectly trying to create a PR from the current branch to itself, causing 'must be on a branch named differently' errors. Root cause: Variable internal_branch was set to the current branch name 'promote/release-{{version}}-update-main' instead of the target branch 'main'. This step is intended to create a PR to merge the updated release images into the main branch, so the --base should be 'main', not the current branch. Fixes the systematic release pipeline failures in promote branches.
1 parent 05b8f2c commit 6e75f27

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

release.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -618,11 +618,11 @@ promoteToPublic:
618618
- name: "github:pr"
619619
cmd: |
620620
set -eu
621-
internal_branch="promote/release-{{version}}-update-main"
621+
# Create PR to merge release updates into main branch
622622
gh pr create \
623623
--fill \
624624
--draft \
625-
--base "$internal_branch" \
625+
--base main \
626626
--title "Update main: build {{version}}" \
627627
--body "Test plan: automated release PR, CI will perform additional checks"
628628
echo "🚢 Please check the associated CI build to ensure the process completed".

0 commit comments

Comments
 (0)