Skip to content

Commit 8610892

Browse files
authored
fix for rendering jaeger Deployment when specifying an image pull secret (#241)
* fix for rendering jaeger Deployment * fixed typo in testing instructions
1 parent 7e1def1 commit 8610892

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

TEST.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ sourcegraph:
5252
# More values to be added in order to test your change
5353
```
5454

55-
Make sure you test both enabled and disabled toggles. For example, if you added a new values to conditional render some templates, turn it on and off in the `overrid.yaml` to make sure they both work. You can also include your `override.yaml` in the `Test plan` during PR review to help others understand your testing strategy.
55+
Make sure you test both enabled and disabled toggles. For example, if you added a new values to conditional render some templates, turn it on and off in the `override.yaml` to make sure they both work. You can also include your `override.yaml` in the `Test plan` during PR review to help others understand your testing strategy.
5656

5757
### Inspect the entire rendered template
5858

charts/sourcegraph/templates/jaeger/jaeger.Deployment.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,8 @@ spec:
9898
{{- with .Values.sourcegraph.imagePullSecrets }}
9999
imagePullSecrets:
100100
{{- toYaml . | nindent 8 }}
101-
{{- include "sourcegraph.renderServiceAccountName" (list . "jaeger") | trim | nindent 6 }}
102101
{{- end }}
102+
{{- include "sourcegraph.renderServiceAccountName" (list . "jaeger") | trim | nindent 6 }}
103103
volumes:
104104
{{- if .Values.jaeger.extraVolumes }}
105105
{{- toYaml .Values.jaeger.extraVolumes | nindent 6 }}

0 commit comments

Comments
 (0)