Skip to content

Commit 998bb3e

Browse files
committed
Fix the chomp, and expand use cases note
1 parent 604350a commit 998bb3e

File tree

1 file changed

+18
-4
lines changed

1 file changed

+18
-4
lines changed

charts/sourcegraph/templates/_helpers.tpl

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -249,19 +249,33 @@ app.kubernetes.io/name: jaeger
249249
{{- end }}
250250

251251
{{/*
252-
Set redisCache and redisStore endpoints
253-
So that customers can configure them any of these ways:
252+
Set redisCache and redisStore endpoints,
253+
so that customers can configure them any of these ways:
254+
254255
1. Create a new Kubernetes secret, with default values (default, no override config required)
256+
255257
2. Use an existing Kubernetes secret, by configuring .Values.redisCache.connection.existingSecret
258+
256259
3. Do not create or use Kubernetes secrets, just pass the default values directly as environment variables into the needed pods, by configuring .Values.sourcegraph.disableKubernetesSecrets = true
257-
4. Do not create or use Kubernetes secrets, but pass custom values (ex. external Redis) directly as environment variables into the needed pods, by configuring .Values.sourcegraph.disableKubernetesSecrets = true, .Values.redisCache.connection.endpoint = "", .Values.redisStore.connection.endpoint = "", and defining the REDIS_CACHE_ENDPOINT and REDIS_STORE_ENDPOINT env vars on frontend, gitserver, searcher, and worker pods
260+
261+
4. Do not create or use Kubernetes secrets, but provide custom values (ex. external Redis) to have this function pass them into the REDIS_CACHE_ENDPOINT and REDIS_STORE_ENDPOINT env vars on frontend, gitserver, searcher, and worker pods, by configuring:
262+
.Values.sourcegraph.disableKubernetesSecrets = true,
263+
.Values.redisCache.connection.endpoint = <custom value for REDIS_CACHE_ENDPOINT>,
264+
.Values.redisStore.connection.endpoint = <custom value for REDIS_STORE_ENDPOINT>,
265+
266+
5. Do not create or use Kubernetes secrets, but pass custom values (ex. external Redis) directly as environment variables into the needed pods, by configuring:
267+
.Values.sourcegraph.disableKubernetesSecrets = true,
268+
.Values.redisCache.connection.endpoint = "",
269+
.Values.redisStore.connection.endpoint = "",
270+
and defining the REDIS_CACHE_ENDPOINT and REDIS_STORE_ENDPOINT env vars on frontend, gitserver, searcher, and worker pods
271+
258272
*/}}
259273
{{- define "sourcegraph.redisConnection" -}}
260274
{{- if .Values.sourcegraph.disableKubernetesSecrets -}}
261275
{{- if .Values.redisCache.connection.endpoint -}}
262276
- name: REDIS_CACHE_ENDPOINT
263277
value: {{ .Values.redisCache.connection.endpoint }}
264-
{{- end -}}
278+
{{ end -}}
265279
{{- if .Values.redisStore.connection.endpoint -}}
266280
- name: REDIS_STORE_ENDPOINT
267281
value: {{ .Values.redisStore.connection.endpoint }}

0 commit comments

Comments
 (0)