Skip to content

Commit ad7fa4a

Browse files
authored
Fix storage class type parameter (#134)
1 parent a51e261 commit ad7fa4a

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

charts/sourcegraph/templates/storageclass.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,9 @@ metadata:
1212
{{- end }}
1313
provisioner: {{ .Values.storageClass.provisioner }}
1414
parameters:
15-
type: {{ .Values.storageClass.type }}
15+
{{- with .Values.storageClass.type }}
16+
type: {{ . }}
17+
{{- end }}
1618
{{- if .Values.storageClass.parameters}}
1719
{{- toYaml .Values.storageClass.parameters | nindent 2 }}
1820
{{- end }}

charts/sourcegraph/tests/storageClass_test.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,3 +12,11 @@ tests:
1212
- equal:
1313
path: parameters.zones
1414
value: us-central1-f
15+
- it: should not have 'type' when storageClass.type=null
16+
set:
17+
storageClass:
18+
create: true
19+
type: null
20+
asserts:
21+
- isNull:
22+
path: parameters

0 commit comments

Comments
 (0)