Skip to content

Commit d5098c7

Browse files
Add envoy filter override (#148)
* Add envoy filter override * Update changelog Co-authored-by: Keegan Carruthers-Smith <[email protected]>
1 parent fd9547f commit d5098c7

File tree

3 files changed

+48
-4
lines changed

3 files changed

+48
-4
lines changed

charts/sourcegraph/CHANGELOG.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,14 @@ Use `**BREAKING**:` to denote a breaking change
33
-->
44

55
# Changelog
6+
67
<!-- START CHANGELOG -->
78

89
## Unreleased
910

10-
## 3.41.1
11-
12-
Sourcegraph 3.41.1 is now available!
11+
### Added
1312

14-
- [Changelog](https://sourcegraph.com/github.com/sourcegraph/sourcegraph/-/blob/CHANGELOG.md#3-41-1)
13+
- Add new example `envoy` to enable HTTP trailers using Envoy Filter [#148](https://github.com/sourcegraph/deploy-sourcegraph-helm/pull/148)
1514

1615
## 3.41.0
1716

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
# Envoy Filter
2+
3+
This override file creates a new resource called `EnvoyFilter` to enable HTTP trailers on envoy for gitserver.
4+
5+
It is an example override file to apply a new envoy filter to resolve the following error message in gitserver caused by service mesh (ex. istio):
6+
7+
```
8+
"git command [git rev-parse HEAD] failed (stderr: \"\"): strconv.Atoi: parsing \"\"
9+
```
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
extraResources:
2+
- apiVersion: networking.istio.io/v1alpha3
3+
kind: EnvoyFilter
4+
metadata:
5+
name: enable-trailers
6+
labels:
7+
deploy: sourcegraph
8+
spec:
9+
workloadSelector:
10+
labels:
11+
app: gitserver
12+
configPatches:
13+
- applyTo: NETWORK_FILTER
14+
match:
15+
listener:
16+
filterChain:
17+
filter:
18+
name: "envoy.filters.network.http_connection_manager"
19+
patch:
20+
operation: MERGE
21+
value:
22+
name: "envoy.filters.network.http_connection_manager"
23+
typed_config:
24+
"@type": "type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager"
25+
http_protocol_options:
26+
enable_trailers: true
27+
- applyTo: CLUSTER
28+
patch:
29+
operation: MERGE
30+
value:
31+
typed_extension_protocol_options:
32+
envoy.extensions.upstreams.http.v3.HttpProtocolOptions:
33+
"@type": type.googleapis.com/envoy.extensions.upstreams.http.v3.HttpProtocolOptions
34+
explicit_http_config:
35+
http_protocol_options:
36+
enable_trailers: true

0 commit comments

Comments
 (0)