Skip to content

Commit ee24ee0

Browse files
authored
sourcegraph: fix storageClass.allowedTopologies default value (#256)
1 parent 2ad1e30 commit ee24ee0

File tree

4 files changed

+2
-10
lines changed

4 files changed

+2
-10
lines changed

charts/sourcegraph/README.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,6 @@ In addition to the documented values, all services also support the following va
134134
| grafana.image.name | string | `"grafana"` | Docker image name for the `grafana` image |
135135
| grafana.name | string | `"grafana"` | Name used by resources. Does not affect service names or PVCs. |
136136
| grafana.podSecurityContext | object | `{"fsGroup":472,"fsGroupChangePolicy":"OnRootMismatch","runAsGroup":472,"runAsUser":472}` | Security context for the `grafana` pod, learn more from the [Kubernetes documentation](https://kubernetes.io/docs/tasks/configure-pod-container/security-context/#set-the-security-context-for-a-pod) |
137-
| grafana.replicaCount | int | `1` | Number of `grafana` pod |
138137
| grafana.resources | object | `{"limits":{"cpu":"1","memory":"512Mi"},"requests":{"cpu":"100m","memory":"512Mi"}}` | Resource requests & limits for the `grafana` container, learn more from the [Kubernetes documentation](https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/) |
139138
| grafana.serviceAccount.create | bool | `true` | Enable creation of ServiceAccount for `grafana` |
140139
| grafana.serviceAccount.name | string | `"grafana"` | Name of the ServiceAccount to be created or an existing ServiceAccount |
@@ -247,7 +246,6 @@ In addition to the documented values, all services also support the following va
247246
| prometheus.name | string | `"prometheus"` | Name used by resources. Does not affect service names or PVCs. |
248247
| prometheus.podSecurityContext | object | `{"fsGroup":100,"fsGroupChangePolicy":"OnRootMismatch"}` | Security context for the `prometheus` pod, learn more from the [Kubernetes documentation](https://kubernetes.io/docs/tasks/configure-pod-container/security-context/#set-the-security-context-for-a-pod) |
249248
| prometheus.privileged | bool | `true` | Enable RBAC for `prometheus` |
250-
| prometheus.replicaCount | int | `1` | Number of `prometheus` pod |
251249
| prometheus.resources | object | `{"limits":{"cpu":"2","memory":"6G"},"requests":{"cpu":"500m","memory":"6G"}}` | Resource requests & limits for the `prometheus` container, learn more from the [Kubernetes documentation](https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/) Prometheus is relied upon to monitor services for sending alerts to site admins when something is wrong with Sourcegraph, thus its memory requests and limits are the same to guarantee it has enough memory to perform its job reliably and prevent conflicts with other pods on the same host node. The limit chosen here is based on what works reliably on Sourcegraph.com with lots of traffic. |
252250
| prometheus.serviceAccount.create | bool | `true` | Enable creation of ServiceAccount |
253251
| prometheus.serviceAccount.name | string | `"prometheus"` | Name of the ServiceAccount to be created or an existing ServiceAccount |
@@ -313,7 +311,7 @@ In addition to the documented values, all services also support the following va
313311
| sourcegraph.revisionHistoryLimit | int | `10` | Global deployment clean up policy, learn more from the [Kubernetes documentation](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#clean-up-policy) |
314312
| sourcegraph.serviceLabels | object | `{}` | Add extra labels to all services |
315313
| sourcegraph.tolerations | list | `[]` | Global Tolerations, learn more from the [Kubernetes documentation](https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/) |
316-
| storageClass.allowedTopologies | object | `{}` | Persistent volumes topology configuration, learn more from the [Kubernetes documentation](https://kubernetes.io/docs/concepts/storage/storage-classes/#allowed-topologies) |
314+
| storageClass.allowedTopologies | list | `[]` | Persistent volumes topology configuration, learn more from the [Kubernetes documentation](https://kubernetes.io/docs/concepts/storage/storage-classes/#allowed-topologies) |
317315
| storageClass.create | bool | `true` | Enable creation of storageClass. Disable if you have your own existing storage class |
318316
| storageClass.name | string | `"sourcegraph"` | Name of the storageClass. Use to customize to the existing storage class name |
319317
| storageClass.parameters | object | `{}` | Extra parameters of storageClass, consult your cloud provider persistent storage documentation |

charts/sourcegraph/templates/grafana/grafana.StatefulSet.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ metadata:
1313
app.kubernetes.io/component: grafana
1414
name: {{ .Values.grafana.name }}
1515
spec:
16-
replicas: {{ .Values.grafana.replicaCount }}
1716
revisionHistoryLimit: {{ .Values.sourcegraph.revisionHistoryLimit }}
1817
selector:
1918
matchLabels:

charts/sourcegraph/templates/prometheus/prometheus.Deployment.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ metadata:
1414
name: {{ .Values.prometheus.name }}
1515
spec:
1616
minReadySeconds: 10
17-
replicas: {{ .Values.prometheus.replicaCount }}
1817
revisionHistoryLimit: {{ .Values.sourcegraph.revisionHistoryLimit }}
1918
selector:
2019
matchLabels:

charts/sourcegraph/values.yaml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -474,8 +474,6 @@ grafana:
474474
readOnlyRootFilesystem: true
475475
# -- Name used by resources. Does not affect service names or PVCs.
476476
name: "grafana"
477-
# -- Number of `grafana` pod
478-
replicaCount: 1
479477
# -- Resource requests & limits for the `grafana` container,
480478
# learn more from the [Kubernetes documentation](https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/)
481479
resources:
@@ -855,8 +853,6 @@ prometheus:
855853
name: "prometheus"
856854
# -- Enable RBAC for `prometheus`
857855
privileged: true
858-
# -- Number of `prometheus` pod
859-
replicaCount: 1
860856
# -- Resource requests & limits for the `prometheus` container,
861857
# learn more from the [Kubernetes documentation](https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/)
862858
# Prometheus is relied upon to monitor services for sending alerts to site admins when
@@ -1093,7 +1089,7 @@ storageClass:
10931089
parameters: {}
10941090
# -- Persistent volumes topology configuration,
10951091
# learn more from the [Kubernetes documentation](https://kubernetes.io/docs/concepts/storage/storage-classes/#allowed-topologies)
1096-
allowedTopologies: {}
1092+
allowedTopologies: []
10971093

10981094
symbols:
10991095
image:

0 commit comments

Comments
 (0)