Skip to content

Commit 3e96188

Browse files
committed
Fix promoteToPublic.finalize github:pr step
The final github:pr step in the promoteToPublic.finalize workflow was incorrectly trying to create a PR from the current branch to itself, causing 'must be on a branch named differently' errors. Root cause: Variable internal_branch was set to the current branch name 'promote/release-{{version}}-update-main' instead of the target branch 'main'. This step is intended to create a PR to merge the updated release images into the main branch, so the --base should be 'main', not the current branch. Fixes the systematic release pipeline failures in promote branches.
1 parent 1ac4f11 commit 3e96188

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

release.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -398,11 +398,11 @@ promoteToPublic:
398398
- name: "github:pr"
399399
cmd: |
400400
set -eu
401-
internal_branch="promote/release-{{version}}-update-main"
401+
# Create PR to merge release updates into main branch
402402
gh pr create \
403403
--fill \
404404
--draft \
405-
--base "$internal_branch" \
405+
--base main \
406406
--title "Update main: build {{version}}" \
407407
--body "Test plan: automated release PR, CI will perform additional checks"
408408
echo "🚢 Please check the associated CI build to ensure the process completed".

0 commit comments

Comments
 (0)