Remove symbols statefulset

Starting in Sourcegraph 6.4, the Symbols and Searcher services are now combined, for easier operation, simplified architecture, and better resource utilization.

Customers can delete the service if not deleted automatically, and may want to consider reallocating resources previously given to symbols to searcher. Environment variables should be copied over from symbols to searcher.

Test plan: This deployment ran for ~2 weeks on S2 and dotcom already and has signoff from team-product-platform.

Author: eseliger

base/monitoring/prometheus/prometheus.yml

@@ -55,9 +55,6 @@ scrape_configs: # Configure targets to scrape
   - job_name: "sourcegraph-statefulsets"
     dns_sd_configs:
       - names:
-          - "symbols.default.svc.cluster.local"
-          - "symbols.ns-sourcegraph.svc.cluster.local"
-          - "symbols.$SG_NAMESPACE.svc.cluster.local"
           - "searcher.default.svc.cluster.local"
           - "searcher.ns-sourcegraph.svc.cluster.local"
           - "searcher.$SG_NAMESPACE.svc.cluster.local"

base/sourcegraph/frontend/sourcegraph-frontend.ConfigMap.yaml

@@ -24,5 +24,4 @@ data:
   PROMETHEUS_URL: http://prometheus:30090
   SRC_GIT_SERVERS: gitserver-0.gitserver:3178
   SEARCHER_URL: http://searcher-0.searcher:3181
-  SYMBOLS_URL: http://symbols:3184
   INDEXED_SEARCH_SERVERS: indexed-search-0.indexed-search:6070

base/sourcegraph/kustomization.yaml

@@ -11,7 +11,6 @@ resources:
   - precise-code-intel
   - redis
   - searcher
-  - symbols
   - syntactic-code-intel
   - syntect-server
   - worker

base/sourcegraph/symbols/kustomization.yaml

@@ -5,27 +5,20 @@ components:
   - ../../monitoring/cadvisor
   - ../../monitoring/rbacs
   - ../../services/searcher/deployment
-  - ../../services/symbols/deployment
   - ../../services/pgsql
   - ../../services/codeinsights-db
   - ../../services/codeintel-db
   # Add sourcegraph as default storage class name
   - ../../storage-class/sourcegraph
   - ../../enable/service-discovery
 patches:
-  # To support searcher and symbols as both statefulset and deployment
+  # To support searcher as both statefulset and deployment
   - path: patches/searcher/searcher.patchesJson6902.yaml
     target:
       group: apps
       kind: StatefulSet|Deployment
       name: searcher
       version: v1
-  - path: patches/symbols/symbols.patchesJson6902.yaml
-    target:
-      group: apps
-      kind: StatefulSet|Deployment
-      name: symbols
-      version: v1
   - path: patches/remove/securityContext-container-0.yaml
     target:
       group: apps

base/sourcegraph/symbols/symbols.Service.yaml

@@ -16,8 +16,6 @@ replicas:
   #   count: 1
   # - name: searcher
   #   count: 1
-  # - name: symbols
-  #   count: 1
   # - name: sourcegraph-frontend
   #   count: 2
   # - name: precise-code-intel-worker

base/sourcegraph/symbols/symbols.StatefulSet.yaml

@@ -348,26 +348,6 @@ patches:
 #                   memory: 500M
 # - patch: |-
 #     apiVersion: apps/v1
-#     kind: StatefulSet
-#     metadata:
-#       name: symbols
-#     spec:
-#       replicas: 1
-#       template:
-#         spec:
-#           containers:
-#             - name: symbols
-#               resources:
-#                 limits:
-#                   cpu: "2"
-#                   ephemeral-storage: "12G"
-#                   memory: 2G
-#                 requests:
-#                   cpu: 500m
-#                   ephemeral-storage: "10G"
-#                   memory: 500M
-# - patch: |-
-#     apiVersion: apps/v1
 #     kind: Deployment
 #     metadata:
 #       name: searcher
@@ -390,26 +370,6 @@ patches:
 #     apiVersion: apps/v1
 #     kind: Deployment
 #     metadata:
-#       name: symbols
-#     spec:
-#       replicas: 1
-#       template:
-#         spec:
-#           containers:
-#             - name: symbols
-#               resources:
-#                 limits:
-#                   cpu: "2"
-#                   ephemeral-storage: "12G"
-#                   memory: 2G
-#                 requests:
-#                   cpu: 500m
-#                   ephemeral-storage: "10G"
-#                   memory: 500M
-# - patch: |-
-#     apiVersion: apps/v1
-#     kind: Deployment
-#     metadata:
 #       name: syntect-server
 #     spec:
 #       replicas: 1