Cleanup documentation around symbols and repo-updater (#1132)

Those two services are removed from our architecture, and workloads are
moved to worker and searcher. This PR removes (hopefully) all remaining
references to those services in our docs.

Test plan: Review.

Author: eseliger

docs/admin/architecture.mdx

@@ -11,11 +11,11 @@
 At its core, Sourcegraph maintains a persistent cache of all repositories that are connected to it. It is persistent because this data is critical for Sourcegraph to function. Still, it is ultimately a cache because the code host is the source of truth, and our cache is eventually consistent.
 
 - `gitserver` is the sharded service that stores repositories and makes them accessible to other Sourcegraph services
-- `repo-updater` is the singleton service responsible for ensuring all repositories in gitserver are as up-to-date as possible while respecting code host rate limits. It is also responsible for syncing repository metadata from the code host that is stored in the repo table of our Postgres database
+- `worker` is responsible for ensuring all repositories in gitserver are as up-to-date as possible while respecting code host rate limits. It is also responsible for syncing repository metadata from the code host that is stored in the repo table of our Postgres database
 
 ## Permission syncing
 
-Repository permissions are mirrored from code hosts to Sourcegraph by default. This builds the foundation of Sourcegraph authorization for repositories to ensure users see consistent content on code hosts. Currently, the background permissions syncer resides in the repo-updater.
+Repository permissions are mirrored from code hosts to Sourcegraph by default. This builds the foundation of Sourcegraph authorization for repositories to ensure users see consistent content on code hosts. Currently, the background permissions syncer resides in the `worker`.
 
 <Callout type="note">Learn more in the [Permission Syncing docs](/admin/permissions/syncing)</Callout>
 
@@ -94,7 +94,7 @@ You can learn more in the [Code Insights](/code_insights) docs.
   - Exhaustive search (with `count:all/count:999999` operator)
   - Historical search (= unindexed search, currently)
   - Commit search to find historical commits to search over
-- Repository Syncing: The code insights backend has direct dependencies on `gitserver` and `repo-updater`
+- Repository Syncing: The code insights backend has a direct dependency on `gitserver`
 - Permission syncing: The code insights backend depends on synced repository permissions for access control
 - Settings cascade:
   - Insights and dashboard configuration are stored in user, organization, and global settings. This will change in the future and is planned to be moved to the database

docs/admin/code_hosts/rate_limits.mdx

@@ -52,7 +52,7 @@ Requests to the configured code host will be staggered as to not exceed `"reques
 - For Sourcegraph `<=3.38`, if rate limiting is configured more than once for the same code host instance, the most restrictive limit will be used.
 - For Sourcegraph >=3.39, rate limiting should be enabled and configured for each individual code host connection.
 
-To see the status of configured internal rate limits, visit **Site admin > Instrumentation > repo-updater > Rate Limiter State**. This page lists internal rate limits by code host, for example:
+To see the status of configured internal rate limits, visit **Site admin > Instrumentation > worker > Rate Limiter State**. This page lists internal rate limits by code host, for example:
 
 ```json
 {

docs/admin/config/postgres-conf.mdx

@@ -53,7 +53,6 @@ The setting `max_connections` determines the number of active connections that c
 | --------------------------- | ------------------------------------------ |
 | `frontend`                  | `pgsql`, `codeintel-db`, `codeinsights-db` |
 | `gitserver`                 | `pgsql`                                    |
-| `repo-updater`              | `pgsql`                                    |
 | `precise-code-intel-worker` | `codeintel-db`, `pgsql`                    |
 | `worker`                    | `codeintel-db`, `pgsql`, `codeinsights-db` |
 

docs/admin/config/private-network.mdx

@@ -19,7 +19,6 @@ services hosted within an organization's private network
     * Connecting to external [LLM providers](../../cody/capabilities/supported-models) with Cody
 - **gitserver**: Executes git commands against externally hosted [code hosts](../external_service)
 - **migrator**: Connects to Postgres instances (which may be [externally hosted](../external_services/postgres)) to process database migrations
-- **repo-updater**: Communicates with [code hosts](../external_service) APIs to coordinate repository synchronization
 - **worker**: Sourcegraph [Worker](../workers) run various background jobs that may require establishing connections to
 services hosted within an organization's private network
 
@@ -34,22 +33,22 @@ variables will depend on your Sourcegraph deployment method.
 Add the proxy environment variables to your Sourcegraph Helm chart [override file](https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/charts/sourcegraph/values.yaml):
 
 ```yaml
-executor|frontend|gitserver|migrator|repo-updater|worker:
+executor|frontend|gitserver|migrator|worker:
   env:
   - name: HTTP_PROXY
     value: http://proxy.example.com:8080
   - name: HTTPS_PROXY
     value: http://proxy.example.com:8080
   - name: NO_PROXY
-    value: "blobstore,codeinsights-db,codeintel-db,sourcegraph-frontend-internal,sourcegraph-frontend,github-proxy,gitserver,grafana,indexed-search-indexer,indexed-search,jaeger-query,pgsql,precise-code-intel-worker,prometheus,redis-cache,redis-store,repo-updater,searcher,symbols,syntect-server,worker-executors,worker,cloud-sql-proxy,localhost,127.0.0.1,.svc,.svc.cluster.local,kubernetes.default.svc"
+    value: "blobstore,codeinsights-db,codeintel-db,sourcegraph-frontend-internal,sourcegraph-frontend,github-proxy,gitserver,grafana,indexed-search-indexer,indexed-search,jaeger-query,pgsql,precise-code-intel-worker,prometheus,redis-cache,redis-store,searcher,syntect-server,worker-executors,worker,cloud-sql-proxy,localhost,127.0.0.1,.svc,.svc.cluster.local,kubernetes.default.svc"
 ```
 
 <Callout type="info">
 If the updated Sourcegraph pods fail to pass their readiness or health checks after configuring the HTTP proxy environment variables, you may also need to add your k8s cluster pod & service CIDR ranges to the `NO_PROXY` environment variable. Example:
 
 ```yaml
 - name: NO_PROXY
-    value: "blobstore,codeinsights-db,codeintel-db,sourcegraph-frontend-internal,sourcegraph-frontend,github-proxy,gitserver,grafana,indexed-search-indexer,indexed-search,jaeger-query,pgsql,precise-code-intel-worker,prometheus,redis-cache,redis-store,repo-updater,searcher,symbols,syntect-server,worker-executors,worker,cloud-sql-proxy,localhost,127.0.0.1,.svc,.svc.cluster.local,kubernetes.default.svc,10.10.0.0/16,10.20.0.0/16"
+    value: "blobstore,codeinsights-db,codeintel-db,sourcegraph-frontend-internal,sourcegraph-frontend,github-proxy,gitserver,grafana,indexed-search-indexer,indexed-search,jaeger-query,pgsql,precise-code-intel-worker,prometheus,redis-cache,redis-store,searcher,syntect-server,worker-executors,worker,cloud-sql-proxy,localhost,127.0.0.1,.svc,.svc.cluster.local,kubernetes.default.svc,10.10.0.0/16,10.20.0.0/16"
 ```
 </Callout>
 
@@ -62,7 +61,7 @@ services:
     environment:
       - HTTP_PROXY=http://proxy.example.com:8080
       - HTTPS_PROXY=http://proxy.example.com:8080
-      - NO_PROXY='blobstore,caddy,cadvisor,codeintel-db,codeintel-db-exporter,codeinsights-db,codeinsights-db-exporter,sourcegraph-frontend-0,sourcegraph-frontend-internal,gitserver-0,grafana,migrator,node-exporter,otel-collector,pgsql,pgsql-exporter,precise-code-intel-worker,prometheus,redis-cache,redis-store,repo-updater,searcher-0,symbols-0,syntect-server,worker,zoekt-indexserver-0,zoekt-webserver-0,localhost,127.0.0.1'
+      - NO_PROXY='blobstore,caddy,cadvisor,codeintel-db,codeintel-db-exporter,codeinsights-db,codeinsights-db-exporter,sourcegraph-frontend-0,sourcegraph-frontend-internal,gitserver-0,grafana,migrator,node-exporter,otel-collector,pgsql,pgsql-exporter,precise-code-intel-worker,prometheus,redis-cache,redis-store,searcher-0,syntect-server,worker,zoekt-indexserver-0,zoekt-webserver-0,localhost,127.0.0.1'
 ```
 
 <Callout type="warning">Failure to configure `NO_PROXY` correctly can cause the proxy configuration to interfere with

docs/admin/deploy/docker-compose/configuration.mdx

@@ -125,7 +125,7 @@ If you must use a `.netrc` file to store these credentials instead, follow the p
 
 ## Add replicas
 
-When adding replicas for `gitserver`, `searcher`, `symbols`, `zoekt-indexserver`, or `zoekt-webserver`, you must update the corresponding environment variable on each of the frontend services in your docker-compose.override.yaml file to the number of replicas for the respective service. Sourcegraph will then automatically infer the containers' endpoints for each replica.
+When adding replicas for `gitserver`, `searcher`, `zoekt-indexserver`, or `zoekt-webserver`, you must update the corresponding environment variable on each of the frontend services in your docker-compose.override.yaml file to the number of replicas for the respective service. Sourcegraph will then automatically infer the containers' endpoints for each replica.
 
 ```yaml
 # docker-compose.override.yaml
@@ -137,15 +137,13 @@ services:
       - 'INDEXED_SEARCH_SERVERS=1'
       - 'SEARCHER_URL=1'
       - 'SRC_GIT_SERVERS=1'
-      - 'SYMBOLS_URL=1'
 
   sourcegraph-frontend-internal:
     environment:
       - 'INDEXED_SEARCH_INDEXERS=1'
       - 'INDEXED_SEARCH_SERVERS=1'
       - 'SEARCHER_URL=1'
       - 'SRC_GIT_SERVERS=1'
-      - 'SYMBOLS_URL=1'
 ```
 
 ## Shard gitserver

docs/admin/deploy/docker-compose/operations.mdx

@@ -71,9 +71,7 @@ prometheus                  /bin/prom-wrapper                Up
 query-runner                /sbin/tini -- /usr/local/b ...   Up
 redis-cache                 /sbin/tini -- redis-server ...   Up                      6379/tcp
 redis-store                 /sbin/tini -- redis-server ...   Up                      6379/tcp
-repo-updater                /sbin/tini -- /usr/local/b ...   Up
 searcher-0                  /sbin/tini -- /usr/local/b ...   Up (healthy)
-symbols-0                   /sbin/tini -- /usr/local/b ...   Up (healthy)            3184/tcp
 syntect-server              sh -c /http-server-stabili ...   Up (healthy)            9238/tcp
 worker                      /sbin/tini -- /usr/local/b ...   Up                      3189/tcp
 zoekt-indexserver-0         /sbin/tini -- zoekt-source ...   Up
@@ -151,9 +149,7 @@ prometheus                  /bin/prom-wrapper                Up
 query-runner                /sbin/tini -- /usr/local/b ...   Up
 redis-cache                 /sbin/tini -- redis-server ...   Up                      6379/tcp
 redis-store                 /sbin/tini -- redis-server ...   Up                      6379/tcp
-repo-updater                /sbin/tini -- /usr/local/b ...   Up
 searcher-0                  /sbin/tini -- /usr/local/b ...   Up (healthy)
-symbols-0                   /sbin/tini -- /usr/local/b ...   Up (healthy)            3184/tcp
 syntect-server              sh -c /http-server-stabili ...   Up (healthy)            9238/tcp
 worker                      /sbin/tini -- /usr/local/b ...   Up                      3189/tcp
 zoekt-indexserver-0         /sbin/tini -- zoekt-source ...   Up
@@ -221,9 +217,7 @@ prometheus                  /bin/prom-wrapper                Up
 query-runner                /sbin/tini -- /usr/local/b ...   Up
 redis-cache                 /sbin/tini -- redis-server ...   Up                      6379/tcp
 redis-store                 /sbin/tini -- redis-server ...   Up                      6379/tcp
-repo-updater                /sbin/tini -- /usr/local/b ...   Up
 searcher-0                  /sbin/tini -- /usr/local/b ...   Up (healthy)
-symbols-0                   /sbin/tini -- /usr/local/b ...   Up (healthy)            3184/tcp
 syntect-server              sh -c /http-server-stabili ...   Up (healthy)            9238/tcp
 worker                      /sbin/tini -- /usr/local/b ...   Up                      3189/tcp
 zoekt-indexserver-0         /sbin/tini -- zoekt-source ...   Up

docs/admin/deploy/kubernetes/configure.mdx

@@ -996,7 +996,7 @@ patches:
 
 You can update environment variables for **searcher** with `patches`.
 
-For example, to update the value for `SEARCHER_CACHE_SIZE_MB`:
+For example, to update the value for `SEARCHER_CACHE_SIZE_MB` and `SEARCHER_CACHE_SIZE_MB`:
 
 ```yaml
 # instances/$INSTANCE_NAME/kustomization.yaml
@@ -1010,21 +1010,6 @@ For example, to update the value for `SEARCHER_CACHE_SIZE_MB`:
           value:
             name: SEARCHER_CACHE_SIZE_MB
             value: "50000"
-```
-
-### Symbols
-
-You can update environment variables for **searcher** with `patches`.
-
-For example, to update the value for `SYMBOLS_CACHE_SIZE_MB`:
-
-```yaml
-# instances/$INSTANCE_NAME/kustomization.yaml
-  patches:
-    - target:
-        name: symbols
-        kind: StatefulSet|Deployment
-      patch: |-
         - op: replace
           path: /spec/template/spec/containers/0/env/0
           value:
@@ -1100,12 +1085,9 @@ Sourcegraph supports specifying an external Redis server with these environment
 
 When using an external Redis server, the corresponding environment variable must also be added to the following services:
 
-
 - `sourcegraph-frontend`
-- `repo-updater`
 - `gitserver`
 - `searcher`
-- `symbols`
 - `worker`
 
 **Step 1**: Include the `services/redis` component in your components:

docs/admin/deploy/kubernetes/index.mdx

@@ -944,11 +944,9 @@ Scale down `deployments` and `statefulSets` that access the database, _this step
 The following services must have their replicas scaled to 0:
  - Deployments (e.g., `kubectl scale deployment <name> --replicas=0`)
 - precise-code-intel-worker
-- repo-updater
 - searcher
 - sourcegraph-frontend
 - sourcegraph-frontend-internal
-- symbols
 - worker
  - Stateful sets (e.g., `kubectl scale sts <name> --replicas=0`):
 - gitserver

docs/admin/deploy/kubernetes/kustomize/migrate.mdx

@@ -15,7 +15,7 @@ Here are the benefits of the new base cluster with the new Kustomize setup compa
 - Streamlined resource allocation process:
   * Allocates resources based on the size of the instance
   * Optimized through load testing
-  * The searcher and symbols use StatefulSets and do not require ephemeral storage
+  * The searcher StatefulSet does not require ephemeral storage
 - Utilizes the Kubernetes-native tool Kustomize:
   * Built into kubectl
   * No additional scripting required
@@ -192,6 +192,8 @@ If your instance was deployed using the non-privileged overlay, you can follow t
 
 ## Step 9: Build and review new manifests
 
+> NOTE: Symbols has been removed in Sourcegraph 6.4.
+
 `pgsql`, `codeinsights-db`, `searcher`, `symbols`, and `codeintel-db` have been changed from `Deployments` to `StatefulSets`. However, redeploying these services as StatefulSets should not affect your existing deployment as they are all configured to use the same PVCs.
 
 ### From Deployment to StatefulSet

docs/admin/deploy/kubernetes/operations.mdx

@@ -429,11 +429,9 @@ precise-code-intel-worker       ClusterIP   10.72.11.102   <none>        3188/TC
 prometheus                      ClusterIP   10.72.12.201   <none>        30090/TCP                    25h
 redis-cache                     ClusterIP   10.72.15.138   <none>        6379/TCP,9121/TCP            25h
 redis-store                     ClusterIP   10.72.4.162    <none>        6379/TCP,9121/TCP            25h
-repo-updater                    ClusterIP   10.72.11.176   <none>        3182/TCP,6060/TCP            25h
 searcher                        ClusterIP   None           <none>        3181/TCP,6060/TCP            23h
 sourcegraph-frontend            ClusterIP   10.72.12.103   <none>        30080/TCP,6060/TCP           25h
 sourcegraph-frontend-internal   ClusterIP   10.72.9.155    <none>        80/TCP                       25h
-symbols                         ClusterIP   None           <none>        3184/TCP,6060/TCP            23h
 syntect-server                  ClusterIP   10.72.14.49    <none>        9238/TCP,6060/TCP            25h
 worker                          ClusterIP   10.72.7.72     <none>        3189/TCP,6060/TCP            25h
 ```