Skip to content

Conversation

@anorrish
Copy link
Contributor

@anorrish anorrish commented Oct 1, 2024

Updating the deployment landing page and including our recommendations.

@vercel
Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sourcegraph-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 5:35pm

Copy link
Contributor

@loujar loujar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, but a few thoughts on the contents of the recommendations:

  1. For Sourcegraph Cloud, we say that we handle "most" of the maintenance, etc. I would personally use the word "all" instead
  2. For k8s helm: I would rephrase "... supported within many Kubernetes-capable environments" to "supported by all mainstream managed Kubernetes platforms"
  3. For k8s helm, I don't quite follow why we refer to kustomize as a "more advanced solution" than helm. That might lead the user to think that kustomize offers greater customization than helm (which is sort of true, but we would want to enhance the templating ability of helm wherever that is the case and can easily address those changes quickly for customers when they come up)

@anorrish anorrish merged commit 3ff1a50 into main Oct 1, 2024
4 of 5 checks passed
@anorrish anorrish deleted the anorrish-deploy-doc-updates branch October 1, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants