Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Bad intelligence on new rev in GitHub PR file lists #383

@efritz

Description

@efritz

We're recently discovered some odd behavior when viewing results from go-langserver via the Sourcegraph browser extension. When on a GitHub PR file list in which a Go file has been added in the new rev, the Go langserver fails to tokenize any Go file in the new revision and no code intelligence appears. This does not seem to affect the original revision.

The failing line is a build context import which always returns a scanner error (expected 'package' but got EOF). Additional debugging shows that the build context attempts to open and return the content of a zero-length file (the file in the new rev). When looking at the temp directories, the zip archives appear to be correct.

See https://github.com/sourcegraph/sourcegraph/issues/9556 for some additional context.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions