Skip to content

Commit b6f8864

Browse files
authored
Merge pull request #25 from olafurpg/javacopts-pure-java
Miscellaneous fixes
2 parents dbc22b0 + f4d9398 commit b6f8864

File tree

3 files changed

+24
-19
lines changed

3 files changed

+24
-19
lines changed

src/main/scala/com/sourcegraph/sbtsourcegraph/SourcegraphEnable.scala

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -28,17 +28,16 @@ object SourcegraphEnable {
2828
val scalacOptionsSettings = Seq(Compile, Test).flatMap(
2929
inConfig(_)(SourcegraphPlugin.relaxScalacOptionsConfigSettings)
3030
)
31+
val semanticdbJavacVersion = Versions.semanticdbJavacVersion()
3132
val settings = for {
3233
(p, semanticdbVersion, overriddenScalaVersion) <- collectProjects(
3334
extracted
3435
)
35-
enableSemanticdbPlugin <-
36+
enableSemanticdbPlugin =
3637
List(
3738
Option(
38-
allDependencies.in(
39-
p
40-
) += "com.sourcegraph" % "semanticdb-javac" % Versions
41-
.semanticdbJavacVersion()
39+
allDependencies.in(p) +=
40+
"com.sourcegraph" % "semanticdb-javac" % semanticdbJavacVersion
4241
),
4342
Option(
4443
javacOptions.in(p) += s"-Xplugin:semanticdb " +
@@ -47,14 +46,16 @@ object SourcegraphEnable {
4746
s"-targetroot:${classDirectory.in(Compile).value.toPath().resolveSibling("semanticdb-classes")}"
4847
),
4948
overriddenScalaVersion.map(v => scalaVersion.in(p) := v),
50-
Option(SemanticdbPlugin.semanticdbEnabled := true),
51-
Option(SemanticdbPlugin.semanticdbVersion := semanticdbVersion)
49+
Option(SemanticdbPlugin.semanticdbEnabled.in(p) := true),
50+
Option(SemanticdbPlugin.semanticdbVersion.in(p) := semanticdbVersion)
5251
).flatten
5352
settings <-
5453
inScope(ThisScope.in(p))(
5554
scalacOptionsSettings
5655
) ++ enableSemanticdbPlugin
5756
} yield settings
57+
println("SETTINGS:")
58+
settings.foreach(println)
5859
Compat.append(extracted, settings, s)
5960
}
6061

@@ -101,6 +102,8 @@ object SourcegraphEnable {
101102
scalacOptionsSettings
102103
) ++ addSemanticdbCompilerPlugin
103104
} yield settings
105+
println("SETTINGS:")
106+
settings.foreach(println)
104107
Compat.append(extracted, settings, s)
105108
}
106109

src/main/scala/com/sourcegraph/sbtsourcegraph/SourcegraphPlugin.scala

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -167,23 +167,25 @@ object SourcegraphPlugin extends AutoPlugin {
167167
},
168168
sourcegraphSemanticdbDirectories := {
169169
val javacTargetroot = sourcegraphJavacTargetroot.value
170-
val jars = fullClasspath.value.map(_.data)
171-
val javacopts =
172-
sourcegraphScalacTargetroot.value / "META-INF" / "semanticdb" / "javacopts.txt"
173-
if (Files.isDirectory(javacopts.toPath().getParent())) {
174-
Files.write(
175-
javacopts.toPath,
176-
List("-classpath", jars.mkString(File.pathSeparator)).asJava,
177-
StandardOpenOption.CREATE,
178-
StandardOpenOption.TRUNCATE_EXISTING
179-
)
170+
val jars = fullClasspath.result.value match {
171+
case Value(value) => value.map(_.data)
172+
case _ => Nil
180173
}
181-
List(
174+
val results = List(
182175
javacTargetroot,
183176
Option(sourcegraphScalacTargetroot.value)
184177
).flatten
185178
.map(f => f / "META-INF" / "semanticdb")
186179
.filter(_.isDirectory())
180+
results.headOption.foreach { dir =>
181+
Files.write(
182+
dir.toPath.resolve("javacopts.txt"),
183+
List("-classpath", jars.mkString(File.pathSeparator)).asJava,
184+
StandardOpenOption.CREATE,
185+
StandardOpenOption.TRUNCATE_EXISTING
186+
)
187+
}
188+
results
187189
}
188190
)
189191

src/main/scala/com/sourcegraph/sbtsourcegraph/Versions.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import scala.collection.JavaConverters._
77
import scala.sys.process._
88

99
object Versions {
10-
def scalametaVersion = "4.4.25"
10+
def scalametaVersion = "4.4.26"
1111
private def semanticdbJavacKey = "semanticdb-javac"
1212

1313
def semanticdbJavacVersion(): String =

0 commit comments

Comments
 (0)