feat: Support code nav for type aliases (#135)

Author: varungandhi-src

indexer/Indexer.cc

@@ -524,6 +524,20 @@ void TuIndexer::saveTagTypeLoc(const clang::TagTypeLoc &tagTypeLoc) {
   }
 }
 
+void TuIndexer::saveTypedefNameDecl(
+    const clang::TypedefNameDecl &typedefNameDecl) {
+  auto optSymbol = this->symbolFormatter.getNamedDeclSymbol(typedefNameDecl);
+  if (!optSymbol.has_value()) {
+    return;
+  }
+  scip::SymbolInformation symbolInfo{};
+  for (auto &docComment : this->tryGetDocComment(typedefNameDecl)) {
+    *symbolInfo.add_documentation() = std::move(docComment.Text);
+  }
+  this->saveDefinition(*optSymbol, typedefNameDecl.getLocation(),
+                       std::move(symbolInfo));
+}
+
 void TuIndexer::saveVarDecl(const clang::VarDecl &varDecl) {
   if (llvm::isa<clang::DecompositionDecl>(&varDecl)) {
     // Individual bindings will be visited by VisitBindingDecl

indexer/SymbolFormatter.cc

@@ -473,6 +473,24 @@ SymbolFormatter::getLocalVarOrParmSymbol(const clang::VarDecl &varDecl) {
   return this->getNextLocalSymbol(varDecl);
 }
 
+std::optional<std::string_view> SymbolFormatter::getTypedefNameSymbol(
+    const clang::TypedefNameDecl &typedefNameDecl) {
+  return this->getSymbolCached(
+      typedefNameDecl, [&]() -> std::optional<std::string> {
+        auto optContextSymbol =
+            this->getContextSymbol(*typedefNameDecl.getDeclContext());
+        if (!optContextSymbol.has_value()) {
+          return {};
+        }
+        return SymbolBuilder::formatContextual(
+            *optContextSymbol,
+            DescriptorBuilder{
+                .name = llvm_ext::toStringView(typedefNameDecl.getName()),
+                .suffix = scip::Descriptor::Type,
+            });
+      });
+}
+
 std::optional<std::string_view>
 SymbolFormatter::getVarSymbol(const clang::VarDecl &varDecl) {
   if (varDecl.isLocalVarDeclOrParm()) {

indexer/SymbolFormatter.h

@@ -24,6 +24,7 @@
   F(Function)                          \
   F(Namespace)                         \
   F(Record)                            \
+  F(TypedefName)                       \
   F(Var)
 
 namespace clang {

test/index/functions/ctors_dtors.snapshot.cc

@@ -2,10 +2,13 @@
 
   template<class T> struct remove_ref      { typedef T type; };
 //                         ^^^^^^^^^^ definition [..] remove_ref#
+//                                                     ^^^^ definition [..] remove_ref#type#
   template<class T> struct remove_ref<T&>  { typedef T type; };
 //                         ^^^^^^^^^^ definition [..] remove_ref#
+//                                                     ^^^^ definition [..] remove_ref#type#
   template<class T> struct remove_ref<T&&> { typedef T type; };
 //                         ^^^^^^^^^^ definition [..] remove_ref#
+//                                                     ^^^^ definition [..] remove_ref#type#
 
   template <typename T>
   typename remove_ref<T>::type&& move(T&& arg) {

test/index/functions/functions.snapshot.cc

@@ -35,6 +35,7 @@
 
   // check that the same canonical type produces the same hash
   using IntAlias = int;
+//      ^^^^^^^^ definition [..] IntAlias#
   void int_to_void_fn(int) {}
 //     ^^^^^^^^^^^^^^ definition [..] int_to_void_fn(d4f767463ce0a6b3).
   void same_hash_as_previous(IntAlias) {}

test/index/functions/operators.snapshot.cc

@@ -130,6 +130,7 @@
     explicit operator const char*() const { return "aaa"; }
 //           ^^^^^^^^ definition [..] IntConvertible#`operator const char *`(a9f41ea0e82d88cf).
     using arr_t = int[3];
+//        ^^^^^ definition [..] IntConvertible#arr_t#
     operator arr_t*() const { return nullptr; }
 //  ^^^^^^^^ definition [..] IntConvertible#`operator int (*)[3]`(a00bb5473f10e296).
   };
@@ -157,6 +158,7 @@
   using size_t = unsigned long long;
   #else
   using size_t = unsigned long;
+//      ^^^^^^ definition [..] size_t#
   #endif
 
   // Override global stuff

test/index/namespaces/namespaces.snapshot.cc

@@ -43,6 +43,7 @@
   }
 
   using C = c::C;
+//      ^ definition [..] C#
 //          ^ reference [..] c/
 //             ^ reference [..] c/C#
 

test/index/types/bad_tagdecl.snapshot.cc

@@ -16,9 +16,11 @@
   template<class T>
   struct enable_if<true, T> { typedef T type; };
 //       ^^^^^^^^^ definition [..] enable_if#
+//                                      ^^^^ definition [..] enable_if#type#
 
   template< bool B, class T = void >
   using enable_if_t = typename enable_if<B,T>::type;
+//      ^^^^^^^^^^^ definition [..] enable_if_t#
 
   template <typename T, typename Enable = void> struct MyTemplate { };
 //                                                     ^^^^^^^^^^ definition [..] MyTemplate#